From: Jon Loeliger <jdl@freescale.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <chriscool@tuxfamily.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH 4/3] bisect: use a detached HEAD to bisect
Date: Fri, 23 May 2008 10:14:49 -0500 [thread overview]
Message-ID: <4836DF69.4060609@freescale.com> (raw)
In-Reply-To: <7v3ao9twfa.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> Christian Couder <chriscool@tuxfamily.org> writes:
>
>> When "git bisect" was first written, it was not possible to
>> checkout a detached HEAD. The detached feature appeared latter.
>> ...
>> This patch makes "git bisect" checkout revisions to be tested on
>> a detached HEAD. This simplifies the code a bit.
>
> Yay!!
>
> One potential worry/downside is "bisect visualize". Because <bisect>
> branch was used for bisection, the _current_ commit has always been
> indicated with a label. HEAD would not get any special label in gitk,
> would it?
Hrm. This seems like a potential issue to me as I occasionally
do want to view where it is and possibly adjust it up or down a
few commits depending on context.
Perhaps a "git bisect addfoo" sort of command is needed? The goal
would be to "add some form of {branch,label,tag}" so it could be named,
seen and possibly moved.
jdl
next prev parent reply other threads:[~2008-05-23 15:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 23:28 [PATCH 4/3] bisect: use a detached HEAD to bisect Christian Couder
2008-05-23 5:35 ` Junio C Hamano
2008-05-23 7:08 ` Christian Couder
2008-05-23 15:14 ` Jon Loeliger [this message]
2008-05-23 15:27 ` Linus Torvalds
2008-05-24 10:51 ` Paul Mackerras
2008-05-24 16:14 ` Linus Torvalds
2008-05-25 0:37 ` Jeff King
2008-05-26 0:15 ` Paul Mackerras
2008-05-26 1:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4836DF69.4060609@freescale.com \
--to=jdl@freescale.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.