From: Junio C Hamano <gitster@pobox.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Christian Couder <chriscool@tuxfamily.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 4/3] bisect: use a detached HEAD to bisect
Date: Sun, 25 May 2008 18:11:22 -0700 [thread overview]
Message-ID: <7v4p8lhnt1.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <18490.280.325614.480038@cargo.ozlabs.ibm.com> (Paul Mackerras's message of "Mon, 26 May 2008 10:15:20 +1000")
Paul Mackerras <paulus@samba.org> writes:
> Linus Torvalds writes:
>
>> Of course, _usually_ it's just the top commit, and it's obvious that way
>> which one is the checked-out one, but if you do "gitk --all" or just
>> generally have multiple branches, right now it's hard to see what commit
>> is the checked-out one, regardless of whether it's detached or not.
>
> If it's not detached, the branch name is in bold, but evidently that's
> either not intuitive or not sufficiently distinct...
>
>> I think "HEAD" in a green box would solve that too, but on the other hand,
>> we have a *lot* of boxes already. For people who mainly just track another
>> repo, you already have one box saying "master", and another one saying
>> "remotes/origin/master", and adding yet *another* box saying HEAD that
>> just points to the same commit will work, but do we really want that?
>>
>> I actually like the red circle for "Local uncommitted changes". Maybe we
>> can use a similar visual clue for "currently checked out". You already
>> picked green for the "added to the index" case, so we have the three
>> primary RGB colors already used, but we could make it just be a deep
>> yellow.
>>
>> Of course, maybe people hate lots of colos already, and something more
>> akin to the text background thing that we use for the selected commit
>> would be better.
>>
>> I dunno. There's so many options.
>>
>> Here's a "make it yellow" patch.
>
> Thanks. I have checked in something similar, that also handles the
> cases where you update the graph and the head has moved, and when you
> do a checkout or reset using the gitk menus.
Thanks. Will pull, but it will have to miss upcoming 1.5.6-rc0,
unfortunately.
prev parent reply other threads:[~2008-05-26 1:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 23:28 [PATCH 4/3] bisect: use a detached HEAD to bisect Christian Couder
2008-05-23 5:35 ` Junio C Hamano
2008-05-23 7:08 ` Christian Couder
2008-05-23 15:14 ` Jon Loeliger
2008-05-23 15:27 ` Linus Torvalds
2008-05-24 10:51 ` Paul Mackerras
2008-05-24 16:14 ` Linus Torvalds
2008-05-25 0:37 ` Jeff King
2008-05-26 0:15 ` Paul Mackerras
2008-05-26 1:11 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4p8lhnt1.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.