From: "H. Peter Anvin" <hpa@zytor.com>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Sam Ravnborg <sam@ravnborg.org>,
Steve French <smfrench@gmail.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: kernel coding style for if ... else which cross #ifdef
Date: Sat, 24 May 2008 11:12:06 -0700 [thread overview]
Message-ID: <48385A76.9020907@zytor.com> (raw)
In-Reply-To: <19f34abd0805240857l57e667fdicb240baf898f6296@mail.gmail.com>
Vegard Nossum wrote:
>
> Why not use all-lowercase config_* names? It seems elegant, and fits
> in with the notion that these are to be used not as macros, but as
> ordinary constants.
>
> (The only disadvantage I can see is that they will stand out less. But
> I don't know how great the disadvantage is.)
>
I think that would be a massive disadvantage. Furthermore, they *can*
(and arguably *should*) still be used for the preprocessor; something like:
#if CFG_BLUTTAN
... at least can be configured to warn on a typo.
-hpa
next prev parent reply other threads:[~2008-05-24 18:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 19:11 kernel coding style for if ... else which cross #ifdef Steve French
2008-05-23 20:42 ` Willy Tarreau
2008-05-23 20:49 ` Adrian Bunk
2008-05-23 21:05 ` Willy Tarreau
2008-05-23 23:03 ` H. Peter Anvin
2008-05-24 5:43 ` Sam Ravnborg
2008-05-24 5:42 ` H. Peter Anvin
2008-05-24 6:42 ` Sam Ravnborg
2008-05-24 10:06 ` Jeremy Fitzhardinge
2008-05-24 10:49 ` Adrian Bunk
2008-05-24 11:27 ` Sam Ravnborg
2008-05-24 14:35 ` Jeremy Fitzhardinge
2008-05-24 14:39 ` Willy Tarreau
2008-05-24 14:41 ` Jeremy Fitzhardinge
2008-05-24 14:46 ` Willy Tarreau
2008-05-24 15:36 ` Sam Ravnborg
2008-05-24 15:45 ` Jeremy Fitzhardinge
2008-05-24 15:57 ` Vegard Nossum
2008-05-24 16:02 ` Jeremy Fitzhardinge
2008-05-24 16:40 ` Tom Spink
2008-05-24 16:42 ` Tom Spink
2008-05-24 20:38 ` Jeremy Fitzhardinge
2008-05-24 20:43 ` H. Peter Anvin
2008-05-24 20:51 ` Jeremy Fitzhardinge
2008-05-24 20:54 ` H. Peter Anvin
2008-05-24 21:15 ` Jeremy Fitzhardinge
2008-05-25 23:57 ` Adrian Bunk
2008-05-26 0:27 ` H. Peter Anvin
2008-05-24 18:12 ` H. Peter Anvin [this message]
2008-05-24 18:12 ` H. Peter Anvin
2008-05-24 18:51 ` Sam Ravnborg
2008-05-24 18:08 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48385A76.9020907@zytor.com \
--to=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=smfrench@gmail.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.