From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too.
Date: Tue, 27 May 2008 23:21:45 +0200 [thread overview]
Message-ID: <483C7B69.5050501@bellard.org> (raw)
In-Reply-To: <5d6222a80805270925t4fea901co91a0464e4e73d362@mail.gmail.com>
Glauber Costa wrote:
> On Tue, May 27, 2008 at 12:34 PM, Fabrice Bellard <fabrice@bellard.org> wrote:
>> Glauber Costa wrote:
>>> Unlike other architectures, i386 lacked a "halted" attribute, going
>>> with a flag into hflags. By using the halted attribute, we can make
>>> the code look like more other architectures, and simplify the code in
>>> some instances. In this commit, we make the code for info_cpus simpler
>>> in monitor.c
>> Good for the I386 halted attribute, as it was a mistake to put in in the
>> hflags. For the memory, hflags should contain only parts of the CPU state
>> known at translation time and should be equal to tb->flags. Most CPUs
>> (including x86 !) do not follow this sane rule.
>
> What about HF_GIF_MASK? It looks like another case of something that
> is mistakenly put into hflags. What do you say?
This is true for: HF_GIF_MASK, HF_HIF_MASK, HF_NMI_MASK.
Fabrice.
next prev parent reply other threads:[~2008-05-27 21:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 15:18 [PATCH 0/6] simplify cpu-exec new spin Glauber Costa
2008-05-27 15:18 ` [Qemu-devel] " Glauber Costa
2008-05-27 15:18 ` [PATCH 1/6] simplify cpu_exec Glauber Costa
2008-05-27 15:18 ` [Qemu-devel] " Glauber Costa
2008-05-27 15:18 ` [PATCH 2/6] Push common interrupt variables to cpu-defs.h Glauber Costa
2008-05-27 15:18 ` [Qemu-devel] " Glauber Costa
2008-05-27 15:18 ` [PATCH 3/6] use halted attribute for i386 too Glauber Costa
2008-05-27 15:18 ` [Qemu-devel] " Glauber Costa
2008-05-27 15:18 ` [PATCH 4/6] simply cpu_exec further Glauber Costa
2008-05-27 15:18 ` [Qemu-devel] " Glauber Costa
2008-05-27 15:18 ` [PATCH 5/6] isolate mmu code in arch-specific function Glauber Costa
2008-05-27 15:18 ` [Qemu-devel] " Glauber Costa
2008-05-27 15:18 ` [PATCH 6/6] cpu-exec-dump Glauber Costa
2008-05-27 15:18 ` [Qemu-devel] " Glauber Costa
2008-05-27 15:38 ` Paul Brook
2008-05-27 15:38 ` Paul Brook
2008-05-27 15:30 ` [Qemu-devel] [PATCH 5/6] isolate mmu code in arch-specific function Fabrice Bellard
2008-05-27 15:42 ` Glauber Costa
2008-05-27 15:36 ` Paul Brook
2008-05-27 15:36 ` Paul Brook
2008-05-27 16:18 ` [Qemu-devel] [PATCH 4/6] simply cpu_exec further Blue Swirl
2008-05-27 16:27 ` Glauber Costa
2008-05-27 15:34 ` [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too Fabrice Bellard
2008-05-27 16:10 ` Blue Swirl
2008-05-27 21:49 ` Glauber Costa
2008-05-27 16:25 ` Glauber Costa
2008-05-27 21:21 ` Fabrice Bellard [this message]
2008-05-27 15:39 ` [Qemu-devel] [PATCH 2/6] Push common interrupt variables to cpu-defs.h Fabrice Bellard
2008-05-27 15:33 ` [PATCH 1/6] simplify cpu_exec Paul Brook
2008-05-27 15:33 ` [Qemu-devel] " Paul Brook
2008-05-27 16:05 ` Blue Swirl
2008-05-27 15:37 ` Fabrice Bellard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483C7B69.5050501@bellard.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.