From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, Glauber Costa <gcosta@redhat.com>
Subject: Re: [PATCH 1/6] simplify cpu_exec
Date: Tue, 27 May 2008 16:33:50 +0100 [thread overview]
Message-ID: <200805271633.51342.paul@codesourcery.com> (raw)
In-Reply-To: <1211901505-30519-2-git-send-email-gcosta@redhat.com>
> +void cpu_load_flags(CPUState *env);
> +void cpu_put_flags(CPUState *env);
These really need a comment saying what they do. The names are not at all
intuitive. Also, why load/put? I'd expect load/save/store or get/put.
> +#if defined(reg_REGWPTR)
> +static uint32_t *saved_regwptr;
> +#endif
Eww. You've replaced reasonably self contained local code with a global
variable hidden deep in target specific code. I plan on adding multithreaded
qemu support soon, so this is a non-starter.
Paul
WARNING: multiple messages have this Message-ID (diff)
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, Glauber Costa <gcosta@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec
Date: Tue, 27 May 2008 16:33:50 +0100 [thread overview]
Message-ID: <200805271633.51342.paul@codesourcery.com> (raw)
In-Reply-To: <1211901505-30519-2-git-send-email-gcosta@redhat.com>
> +void cpu_load_flags(CPUState *env);
> +void cpu_put_flags(CPUState *env);
These really need a comment saying what they do. The names are not at all
intuitive. Also, why load/put? I'd expect load/save/store or get/put.
> +#if defined(reg_REGWPTR)
> +static uint32_t *saved_regwptr;
> +#endif
Eww. You've replaced reasonably self contained local code with a global
variable hidden deep in target specific code. I plan on adding multithreaded
qemu support soon, so this is a non-starter.
Paul
next prev parent reply other threads:[~2008-05-27 15:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 15:18 [PATCH 0/6] simplify cpu-exec new spin Glauber Costa
2008-05-27 15:18 ` [Qemu-devel] " Glauber Costa
2008-05-27 15:18 ` [PATCH 1/6] simplify cpu_exec Glauber Costa
2008-05-27 15:18 ` [Qemu-devel] " Glauber Costa
2008-05-27 15:18 ` [PATCH 2/6] Push common interrupt variables to cpu-defs.h Glauber Costa
2008-05-27 15:18 ` [Qemu-devel] " Glauber Costa
2008-05-27 15:18 ` [PATCH 3/6] use halted attribute for i386 too Glauber Costa
2008-05-27 15:18 ` [Qemu-devel] " Glauber Costa
2008-05-27 15:18 ` [PATCH 4/6] simply cpu_exec further Glauber Costa
2008-05-27 15:18 ` [Qemu-devel] " Glauber Costa
2008-05-27 15:18 ` [PATCH 5/6] isolate mmu code in arch-specific function Glauber Costa
2008-05-27 15:18 ` [Qemu-devel] " Glauber Costa
2008-05-27 15:18 ` [PATCH 6/6] cpu-exec-dump Glauber Costa
2008-05-27 15:18 ` [Qemu-devel] " Glauber Costa
2008-05-27 15:38 ` Paul Brook
2008-05-27 15:38 ` Paul Brook
2008-05-27 15:30 ` [Qemu-devel] [PATCH 5/6] isolate mmu code in arch-specific function Fabrice Bellard
2008-05-27 15:42 ` Glauber Costa
2008-05-27 15:36 ` Paul Brook
2008-05-27 15:36 ` Paul Brook
2008-05-27 16:18 ` [Qemu-devel] [PATCH 4/6] simply cpu_exec further Blue Swirl
2008-05-27 16:27 ` Glauber Costa
2008-05-27 15:34 ` [Qemu-devel] [PATCH 3/6] use halted attribute for i386 too Fabrice Bellard
2008-05-27 16:10 ` Blue Swirl
2008-05-27 21:49 ` Glauber Costa
2008-05-27 16:25 ` Glauber Costa
2008-05-27 21:21 ` Fabrice Bellard
2008-05-27 15:39 ` [Qemu-devel] [PATCH 2/6] Push common interrupt variables to cpu-defs.h Fabrice Bellard
2008-05-27 15:33 ` Paul Brook [this message]
2008-05-27 15:33 ` [Qemu-devel] [PATCH 1/6] simplify cpu_exec Paul Brook
2008-05-27 16:05 ` Blue Swirl
2008-05-27 15:37 ` Fabrice Bellard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805271633.51342.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=gcosta@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.