Re: [PATCH] Add port multiplier (PMP) support in sata_fsl driver

[Jeff Garzik <jgarzik@pobox.com>]

Kumar Gala wrote:
> From: Ashish Kalra <ashish.kalra@freescale.com>
> 
> PMP support for sata_fsl driver.
> 
> Signed-off-by: Ashish Kalra <ashish.kalra@freescale.com>
> ---
> Jeff,
> 
> The following commit (4c9bf4e799ce06a7378f1196587084802a414c03):
> libata: replace tf_read with qc_fill_rtf for non-SFF drivers
> 
> Broke the sata_fsl.c driver in 2.6.26.  I know the following patch fixes
> the issue, it clearly also adds port multipler support.  I'm not sure if
> you are willing to take that as part of 2.6.26 or not, but the current
> 2.6.26 driver is broken.
> 
> On boot with debug enabled we get something like (w/o this patch):
> 
> spurious interrupt!!, CC = 0x1
> interrupt status 0x1
> xx_scr_read, reg_in = 1
> spurious interrupt!!, CC = 0x1
> interrupt status 0x1
> xx_scr_read, reg_in = 1
> spurious interrupt!!, CC = 0x1
> interrupt status 0x1
> xx_scr_read, reg_in = 1
> 
> .. continues for ever.
> 
> - k
> 
>  drivers/ata/sata_fsl.c |  224 +++++++++++++++++++++++++++++++++++-------------
>  1 files changed, 163 insertions(+), 61 deletions(-)
> 

applied