All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Peng Fan <peng.fan@nxp.com>,
	"rafael@kernel.org" <rafael@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	Peng Fan <peng.fan@oss.nxp.com>
Cc: "amitk@kernel.org" <amitk@kernel.org>,
	"rui.zhang@intel.com" <rui.zhang@intel.com>,
	"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Alice Guo <alice.guo@nxp.com>
Subject: Re: [PATCH 2/3] thermal: qoriq_thermal: only enable supported sensors
Date: Thu, 15 Jun 2023 04:53:17 +0200	[thread overview]
Message-ID: <4844567.31r3eYUQgx@pliszka> (raw)
In-Reply-To: <2e57d14a-214e-c3e0-e011-e804ce8c9b39@oss.nxp.com>

On czwartek, 15 czerwca 2023 04:29:01 CEST Peng Fan wrote:
> On 6/8/2023 3:10 AM, Daniel Lezcano wrote:
> >
> > [...]
> >
> > Ok, I misunderstood. I thought that was for failing registered thermal
> > zone.
> > 
> > Would enabling the site in ops->change_mode do the trick ?
> 
> No. ops->change_mode not able to do the trick.
> 
> devm_thermal_of_zone_register->thermal_zone_device_enable
> ->thermal_zone_device_set_mode->__thermal_zone_device_update.part.0
> ->__thermal_zone_get_temp
> 
> The thermal_zone_device_set_mode will call change_mode, if return
> fail here, the thermal zone will fail to be registered.
> 
> Thanks,
> Peng.

I think the idea is not to return a failure in ops->change_mode, but to move 
enabling the site in REGS_TMR/REGS_V2_TMSR register from 
qoriq_tmu_register_tmu_zone to ops->change_mode. This way the site will be 
enabled only for actually existing thermal zones, since those not described in 
the device tree won't reach thermal_zone_device_enable.

S.



WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Peng Fan <peng.fan@nxp.com>,
	"rafael@kernel.org" <rafael@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	Peng Fan <peng.fan@oss.nxp.com>
Cc: "amitk@kernel.org" <amitk@kernel.org>,
	"rui.zhang@intel.com" <rui.zhang@intel.com>,
	"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Alice Guo <alice.guo@nxp.com>
Subject: Re: [PATCH 2/3] thermal: qoriq_thermal: only enable supported sensors
Date: Thu, 15 Jun 2023 04:53:17 +0200	[thread overview]
Message-ID: <4844567.31r3eYUQgx@pliszka> (raw)
In-Reply-To: <2e57d14a-214e-c3e0-e011-e804ce8c9b39@oss.nxp.com>

On czwartek, 15 czerwca 2023 04:29:01 CEST Peng Fan wrote:
> On 6/8/2023 3:10 AM, Daniel Lezcano wrote:
> >
> > [...]
> >
> > Ok, I misunderstood. I thought that was for failing registered thermal
> > zone.
> > 
> > Would enabling the site in ops->change_mode do the trick ?
> 
> No. ops->change_mode not able to do the trick.
> 
> devm_thermal_of_zone_register->thermal_zone_device_enable
> ->thermal_zone_device_set_mode->__thermal_zone_device_update.part.0
> ->__thermal_zone_get_temp
> 
> The thermal_zone_device_set_mode will call change_mode, if return
> fail here, the thermal zone will fail to be registered.
> 
> Thanks,
> Peng.

I think the idea is not to return a failure in ops->change_mode, but to move 
enabling the site in REGS_TMR/REGS_V2_TMSR register from 
qoriq_tmu_register_tmu_zone to ops->change_mode. This way the site will be 
enabled only for actually existing thermal zones, since those not described in 
the device tree won't reach thermal_zone_device_enable.

S.



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-06-15  2:53 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16  8:37 [PATCH 0/3] thermal: qoriq_thermal: support TMU 2.1 Peng Fan (OSS)
2023-05-16  8:37 ` Peng Fan (OSS)
2023-05-16  8:37 ` [PATCH 1/3] thermal: qoriq_thermal: No need to program site adjustment register Peng Fan (OSS)
2023-05-16  8:37   ` Peng Fan (OSS)
2023-05-16  8:37 ` [PATCH 2/3] thermal: qoriq_thermal: only enable supported sensors Peng Fan (OSS)
2023-05-16  8:37   ` Peng Fan (OSS)
2023-05-31 11:03   ` Daniel Lezcano
2023-05-31 11:03     ` Daniel Lezcano
2023-05-31 12:05     ` Peng Fan
2023-05-31 12:05       ` Peng Fan
2023-05-31 12:35       ` Daniel Lezcano
2023-05-31 12:35         ` Daniel Lezcano
2023-05-31 13:00         ` Peng Fan
2023-05-31 13:00           ` Peng Fan
2023-06-01  9:52           ` Peng Fan
2023-06-01  9:52             ` Peng Fan
2023-06-02 13:11             ` Daniel Lezcano
2023-06-02 13:11               ` Daniel Lezcano
2023-06-07  6:01               ` Sebastian Krzyszkowiak
2023-06-07  6:01                 ` Sebastian Krzyszkowiak
2023-06-07  8:28                 ` Daniel Lezcano
2023-06-07  8:28                   ` Daniel Lezcano
2023-06-07 17:42                   ` Sebastian Krzyszkowiak
2023-06-07 17:42                     ` Sebastian Krzyszkowiak
2023-06-07 19:10                     ` Daniel Lezcano
2023-06-07 19:10                       ` Daniel Lezcano
2023-06-12  6:23                       ` Sebastian Krzyszkowiak
2023-06-15  2:29                       ` Peng Fan
2023-06-15  2:29                         ` Peng Fan
2023-06-15  2:53                         ` Sebastian Krzyszkowiak [this message]
2023-06-15  2:53                           ` Sebastian Krzyszkowiak
2023-06-15  4:04                           ` Peng Fan
2023-06-15  4:04                             ` Peng Fan
2023-06-15 10:36                             ` Daniel Lezcano
2023-06-15 10:36                               ` Daniel Lezcano
2023-06-15 11:48                             ` Daniel Lezcano
2023-06-15 11:48                               ` Daniel Lezcano
2023-06-15 12:07                               ` Peng Fan
2023-06-15 12:07                                 ` Peng Fan
2023-06-15 13:49                                 ` Daniel Lezcano
2023-06-15 13:49                                   ` Daniel Lezcano
2023-06-16  1:06                                   ` Peng Fan
2023-06-16  1:06                                     ` Peng Fan
2023-06-16  9:01                                     ` Daniel Lezcano
2023-06-16  9:01                                       ` Daniel Lezcano
2023-05-16  8:37 ` [PATCH 3/3] thermal: qoriq: support version 2.1 Peng Fan (OSS)
2023-05-16  8:37   ` Peng Fan (OSS)
2023-05-23  1:59 ` [PATCH 0/3] thermal: qoriq_thermal: support TMU 2.1 Alice Guo
2023-05-23  1:59   ` Alice Guo
2023-05-29  3:35 ` Peng Fan
2023-05-29  3:35   ` Peng Fan
2023-06-16  9:02 ` Daniel Lezcano
2023-06-16  9:02   ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4844567.31r3eYUQgx@pliszka \
    --to=sebastian.krzyszkowiak@puri.sm \
    --cc=alice.guo@nxp.com \
    --cc=amitk@kernel.org \
    --cc=andrew.smirnov@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.