From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] pinctrl: sh-pfc: use a saner Kconfig symbol
Date: Sun, 31 Aug 2014 20:22:53 +0300 [thread overview]
Message-ID: <4845771.kPKGOTpt3B@avalon> (raw)
In-Reply-To: <1409316719-28904-1-git-send-email-linus.walleij@linaro.org>
Hi Linus,
Thank you for the patch.
On Friday 29 August 2014 14:51:59 Linus Walleij wrote:
> There is currently a kludge to get the Makefile to move down
> to sh-pfc:s drivers: the arch definitions are used twice to
> get it done. However we can very well use the Kconfig symbol
> for the SH PFC pin control feature itself: it doesn't matter
> that it comes from a lower leaf in the Kconfig hierarchy which
> is completely orthogonal.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/pinctrl/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
> index 7ebb3c5a9c30..0ffe1f608c67 100644
> --- a/drivers/pinctrl/Makefile
> +++ b/drivers/pinctrl/Makefile
> @@ -60,8 +60,7 @@ obj-$(CONFIG_PLAT_ORION) += mvebu/
> obj-y += nomadik/
> obj-$(CONFIG_ARCH_QCOM) += qcom/
> obj-$(CONFIG_PINCTRL_SAMSUNG) += samsung/
> -obj-$(CONFIG_ARCH_SHMOBILE) += sh-pfc/
> -obj-$(CONFIG_SUPERH) += sh-pfc/
> +obj-$(CONFIG_PINCTRL_SH_PFC) += sh-pfc/
> obj-$(CONFIG_PLAT_SPEAR) += spear/
> obj-$(CONFIG_ARCH_SUNXI) += sunxi/
> obj-$(CONFIG_ARCH_VT8500) += vt8500/
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: sh-pfc: use a saner Kconfig symbol
Date: Sun, 31 Aug 2014 20:22:53 +0300 [thread overview]
Message-ID: <4845771.kPKGOTpt3B@avalon> (raw)
In-Reply-To: <1409316719-28904-1-git-send-email-linus.walleij@linaro.org>
Hi Linus,
Thank you for the patch.
On Friday 29 August 2014 14:51:59 Linus Walleij wrote:
> There is currently a kludge to get the Makefile to move down
> to sh-pfc:s drivers: the arch definitions are used twice to
> get it done. However we can very well use the Kconfig symbol
> for the SH PFC pin control feature itself: it doesn't matter
> that it comes from a lower leaf in the Kconfig hierarchy which
> is completely orthogonal.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/pinctrl/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
> index 7ebb3c5a9c30..0ffe1f608c67 100644
> --- a/drivers/pinctrl/Makefile
> +++ b/drivers/pinctrl/Makefile
> @@ -60,8 +60,7 @@ obj-$(CONFIG_PLAT_ORION) += mvebu/
> obj-y += nomadik/
> obj-$(CONFIG_ARCH_QCOM) += qcom/
> obj-$(CONFIG_PINCTRL_SAMSUNG) += samsung/
> -obj-$(CONFIG_ARCH_SHMOBILE) += sh-pfc/
> -obj-$(CONFIG_SUPERH) += sh-pfc/
> +obj-$(CONFIG_PINCTRL_SH_PFC) += sh-pfc/
> obj-$(CONFIG_PLAT_SPEAR) += spear/
> obj-$(CONFIG_ARCH_SUNXI) += sunxi/
> obj-$(CONFIG_ARCH_VT8500) += vt8500/
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-08-31 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 12:51 [PATCH] pinctrl: sh-pfc: use a saner Kconfig symbol Linus Walleij
2014-08-29 12:51 ` Linus Walleij
2014-08-31 17:22 ` Laurent Pinchart [this message]
2014-08-31 17:22 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4845771.kPKGOTpt3B@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.