Re: [PATCH] Accounting rework: ct_extend + 64bit counters

[Patrick McHardy <kaber@trash.net>]

Krzysztof Oledzki wrote:
> 
> 
> On Tue, 3 Jun 2008, Patrick McHardy wrote:
> 
>> Krzysztof Oledzki wrote:
>>>> Mhh good point :) I was thinking of calling it from the raw table,
>>>> but of course we don't have a conntrack at that point. So the
>>>> information would have to be propagated from the raw table somehow.
>>>> Maybe something like the untracked conntrack? IIRC someone posted
>>>> a patch for something similar (propagation of parameters to helpers)
>>>> some time ago.
>>>
>>> OK, I'll look at this. Can we push the current version (plus 
>>> discussed changes) now and tag if for 2.6.27 and try to solve above 
>>> problem later (2.6.28)?
>>
>> I would prefer to see a final solution before pushing
>> it upstream. Having it only implemented half-way forces
>> an additional allocation on everyone (even those not
>> even compiling the feature in now) for now gain.
> 
> Not really as my patch makes possible do disable accounting, I even 
> initially proposed to disable it by default. If accounting is disabled 
> then there is no additional allocation.


Yes, but then I'll get a bunch of bug reports :) And its
unlikely that most people will notice or touch this value.