* Re: [PATCH] Clear CR4.VMXE in hardware_disable [not found] <Pine.LNX.4.64.0806012023270.5992@ecollins-dev1.eng.vmware.com> @ 2008-06-04 10:15 ` Avi Kivity 2008-06-04 17:34 ` Eli Collins 0 siblings, 1 reply; 2+ messages in thread From: Avi Kivity @ 2008-06-04 10:15 UTC (permalink / raw) To: Eli Collins; +Cc: kvm Eli Collins wrote: > > Clear CR4.VMXE in hardware_disable. There's no reason to leave it set > after doing a VMXOFF. > > VMware Workstation 6.5 checks CR4.VMXE as a proxy for whether the CPU > is in VMX mode, so leaving VMXE set means we'll refuse to power on. > With this change the user can power on after unloading the kvm-intel > module. I tested on kvm-67 and kvm-69. Applied, thanks. The patch was whitespace-mangled though. Did you cut'n'paste into your email client? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Clear CR4.VMXE in hardware_disable 2008-06-04 10:15 ` [PATCH] Clear CR4.VMXE in hardware_disable Avi Kivity @ 2008-06-04 17:34 ` Eli Collins 0 siblings, 0 replies; 2+ messages in thread From: Eli Collins @ 2008-06-04 17:34 UTC (permalink / raw) To: Avi Kivity; +Cc: kvm On Wed, 4 Jun 2008, Avi Kivity wrote: > Eli Collins wrote: >> >> Clear CR4.VMXE in hardware_disable. There's no reason to leave it set after >> doing a VMXOFF. >> >> VMware Workstation 6.5 checks CR4.VMXE as a proxy for whether the CPU is in >> VMX mode, so leaving VMXE set means we'll refuse to power on. With this >> change the user can power on after unloading the kvm-intel module. I tested >> on kvm-67 and kvm-69. > > Applied, thanks. The patch was whitespace-mangled though. Did you > cut'n'paste into your email client? Thanks for the heads up. It's probably pine, I need to change some config options. I redirected the output of git diff to a file and then used pine's read file to include it. Btw, maybe of interest, I also tested that workstation and kvm-69 play nicely on SVM, you can run both simultaneously w/o issue (which was expected). Thanks, Eli ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-04 17:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <Pine.LNX.4.64.0806012023270.5992@ecollins-dev1.eng.vmware.com>
2008-06-04 10:15 ` [PATCH] Clear CR4.VMXE in hardware_disable Avi Kivity
2008-06-04 17:34 ` Eli Collins
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.