* [ULOGD PATCH] Fix crash when using NFCT with hash_enable=0.
@ 2008-06-04 8:38 Eric Leblond
2008-06-04 13:19 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Eric Leblond @ 2008-06-04 8:38 UTC (permalink / raw)
To: pablo, netfilter-devel; +Cc: regit
From: regit <regit@ghlodit.inl.fr>
This patch fixes NFCT when hash_enable is 0. Limitation of treatment to NFCT_DESTROY
message type causes usage of the hashtable function and hence a crash because it is
not initiated.
Signed-off-by: regit <regit@ghlodit.inl.fr>
---
input/flow/ulogd_inpflow_NFCT.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/input/flow/ulogd_inpflow_NFCT.c b/input/flow/ulogd_inpflow_NFCT.c
index dfb58d5..2a44780 100644
--- a/input/flow/ulogd_inpflow_NFCT.c
+++ b/input/flow/ulogd_inpflow_NFCT.c
@@ -625,7 +625,7 @@ static int event_handler(enum nf_conntrack_msg_type type,
.ct = ct,
};
- if (!usehash_ce(upi->config_kset).u.value && type == NFCT_T_DESTROY) {
+ if (!usehash_ce(upi->config_kset).u.value) {
switch(type) {
case NFCT_T_NEW:
gettimeofday(&tmp.time[START], NULL);
--
1.5.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [ULOGD PATCH] Fix crash when using NFCT with hash_enable=0.
2008-06-04 8:38 [ULOGD PATCH] Fix crash when using NFCT with hash_enable=0 Eric Leblond
@ 2008-06-04 13:19 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2008-06-04 13:19 UTC (permalink / raw)
To: Eric Leblond; +Cc: pablo, netfilter-devel, regit
Eric Leblond wrote:
> From: regit <regit@ghlodit.inl.fr>
>
> This patch fixes NFCT when hash_enable is 0. Limitation of treatment to NFCT_DESTROY
> message type causes usage of the hashtable function and hence a crash because it is
> not initiated.
>
> Signed-off-by: regit <regit@ghlodit.inl.fr>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-04 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-04 8:38 [ULOGD PATCH] Fix crash when using NFCT with hash_enable=0 Eric Leblond
2008-06-04 13:19 ` Patrick McHardy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.