All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linuxppc-dev@ozlabs.org,
	Anton Vorontsov <avorontsov@ru.mvista.com>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] [NAND] driver extension to support NAND on TQM85xx modules
Date: Sun, 08 Jun 2008 20:01:51 +0200	[thread overview]
Message-ID: <484C1E8F.4010900@grandegger.com> (raw)
In-Reply-To: <1212825701.32207.403.camel@pmac.infradead.org>

David Woodhouse wrote:
> On Thu, 2008-06-05 at 10:50 +0200, Wolfgang Grandegger wrote:
>> [NAND] driver extension to support NAND on TQM85xx modules
>>
>> This patch extends the FSL UPM NAND driver from Anton Vorontsov to
>> support NAND on the TQM85xx modules. Unfortunately, the hardware does
>> not support the R/B pins of the NAND chip and therefore the specified
>> maximum delay time must used. It therefore re-introduces the chip-delay
>> property.
>>
>> Note: this patch is based on various patches from  Anton Vorontsov posted
>>       to this list:
>>
>>       http://ozlabs.org/pipermail/linuxppc-dev/2008-April/055587.html.
> 
> Do you also want me to apply that patch (on which this one depends)?
> It says 'Signed-off-by: not yet' ...

Anton has already answer that question.

> You should probably comment on the removal of the OF_GPIO dependency. It
> looks fine, since the relevant functions all get stubbed out and will do
> the right thing, but it's worth a comment in the commit text.

OK, will do so.

Wolfgang.

WARNING: multiple messages have this Message-ID (diff)
From: Wolfgang Grandegger <wg@grandegger.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] [NAND] driver extension to support NAND on TQM85xx modules
Date: Sun, 08 Jun 2008 20:01:51 +0200	[thread overview]
Message-ID: <484C1E8F.4010900@grandegger.com> (raw)
In-Reply-To: <1212825701.32207.403.camel@pmac.infradead.org>

David Woodhouse wrote:
> On Thu, 2008-06-05 at 10:50 +0200, Wolfgang Grandegger wrote:
>> [NAND] driver extension to support NAND on TQM85xx modules
>>
>> This patch extends the FSL UPM NAND driver from Anton Vorontsov to
>> support NAND on the TQM85xx modules. Unfortunately, the hardware does
>> not support the R/B pins of the NAND chip and therefore the specified
>> maximum delay time must used. It therefore re-introduces the chip-delay
>> property.
>>
>> Note: this patch is based on various patches from  Anton Vorontsov posted
>>       to this list:
>>
>>       http://ozlabs.org/pipermail/linuxppc-dev/2008-April/055587.html.
> 
> Do you also want me to apply that patch (on which this one depends)?
> It says 'Signed-off-by: not yet' ...

Anton has already answer that question.

> You should probably comment on the removal of the OF_GPIO dependency. It
> looks fine, since the relevant functions all get stubbed out and will do
> the right thing, but it's worth a comment in the commit text.

OK, will do so.

Wolfgang.

  parent reply	other threads:[~2008-06-08 18:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-05  8:50 [PATCH v2] [NAND] driver extension to support NAND on TQM85xx modules Wolfgang Grandegger
2008-06-05  8:50 ` Wolfgang Grandegger
2008-06-07  8:01 ` David Woodhouse
2008-06-07  8:01   ` David Woodhouse
2008-06-07 11:44   ` Anton Vorontsov
2008-06-07 11:44     ` Anton Vorontsov
2008-06-08 18:05     ` Wolfgang Grandegger
2008-06-08 19:39       ` Segher Boessenkool
2008-06-08 19:39         ` Segher Boessenkool
2008-06-09  8:44         ` Wolfgang Grandegger
2008-06-09  8:44           ` Wolfgang Grandegger
2008-06-08 18:01   ` Wolfgang Grandegger [this message]
2008-06-08 18:01     ` Wolfgang Grandegger
2008-06-09  8:32   ` Wolfgang Grandegger
2008-06-09  8:32     ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484C1E8F.4010900@grandegger.com \
    --to=wg@grandegger.com \
    --cc=avorontsov@ru.mvista.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.