[PATCH] Changed type field to be %x for tree header (line in btrfs_print_tree)

[PATCH] Changed type field to be %x for tree header (line in btrfs_print_tree)

[Alan D. Brunelle]

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 0001-Changed-type-field-to-be-x-for-tree-header-like-in.patch --]
[-- Type: text/x-diff, Size: 758 bytes --]

This makes it easier to visually match keys - see:
print-tree.c:btrfs_print_tree():329:

	printf("\tkey %d (%llu %x %llu) block %llu (%llu) gen %llu\n",

I'm not sure if this breaks any other parsers?

Signed-off-by: Alan D. Brunelle <alan.brunelle@hp.com>
---
 debug-tree.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/debug-tree.c b/debug-tree.c
index fa5c90c..9185dc2 100644
--- a/debug-tree.c
+++ b/debug-tree.c
@@ -190,7 +190,7 @@ int main(int ac, char **av)
 				break;
 			}
 			if (!skip && !extent_only) {
-				printf("tree %llu %u %llu\n",
+				printf("tree %llu %x %llu\n",
 				       (unsigned long long)found_key.objectid,
 				       found_key.type,
 				       (unsigned long long)found_key.offset);
-- 
1.5.4.3

Re: [PATCH] Changed type field to be %x for tree header (line in btrfs_print_tree)

[Chris Mason]

[ use %x for key type printks ]

I've gone back and forth on this, since the type used to be a mask.
But, right now all the #defines are in decimal, I'd rather keep the
output the same way.

-chris

Re: [PATCH] Changed type field to be %x for tree header (line in btrfs_print_tree)

[Alan D. Brunelle]

Chris Mason wrote:
> [ use %x for key type printks ]
> 
> I've gone back and forth on this, since the type used to be a mask.
> But, right now all the #defines are in decimal, I'd rather keep the
> output the same way.
> 
> -chris

Then, perhaps, one should change the %x in
print-tree.c:btrfs_print_tree() to a %u?

Alan