[PATCH] sfc: Recover from RX queue flush failure

[PATCH] sfc: Recover from RX queue flush failure

[Ben Hutchings]

From: Steve Hodgson <shodgson@solarflare.com>

RX queue flush can fail if traffic continues to arrive.  Recover by
performing an invisible reset.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
 drivers/net/sfc/falcon.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/net/sfc/falcon.c b/drivers/net/sfc/falcon.c
index cbe2e83..f2d361f 100644
--- a/drivers/net/sfc/falcon.c
+++ b/drivers/net/sfc/falcon.c
@@ -842,8 +842,10 @@ void falcon_fini_rx(struct efx_rx_queue *rx_queue)
 			continue;
 		break;
 	}
-	if (rc)
+	if (rc) {
 		EFX_ERR(efx, "failed to flush rx queue %d\n", rx_queue->queue);
+		efx_schedule_reset(efx, RESET_TYPE_INVISIBLE);
+	}
 
 	/* Remove RX descriptor ring from card */
 	EFX_ZERO_OWORD(rx_desc_ptr);

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.

Re: [PATCH] sfc: Recover from RX queue flush failure

[Jeff Garzik]

Ben Hutchings wrote:
> From: Steve Hodgson <shodgson@solarflare.com>
> 
> RX queue flush can fail if traffic continues to arrive.  Recover by
> performing an invisible reset.
> 
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
>  drivers/net/sfc/falcon.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)

applied