From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: linuxppc-dev list <Linuxppc-dev@ozlabs.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [RFC:PATCH 06/06] powerpc: Don't clear _PAGE_COHERENT when _PAGE_SAO is set
Date: Wed, 11 Jun 2008 02:26:14 +0400 [thread overview]
Message-ID: <484EFF86.1030709@ru.mvista.com> (raw)
In-Reply-To: <20080610220129.10257.69024.sendpatchset@norville.austin.ibm.com>
Hello.
Dave Kleikamp wrote:
> powerpc: Don't clear _PAGE_COHERENT when _PAGE_SAO is set
>
> This is a placeholder. Benh tells me that he will come up with a better fix.
>
> Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
> ---
>
> arch/powerpc/platforms/pseries/lpar.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -Nurp linux005/arch/powerpc/platforms/pseries/lpar.c linux006/arch/powerpc/platforms/pseries/lpar.c
> --- linux005/arch/powerpc/platforms/pseries/lpar.c 2008-06-05 10:07:34.000000000 -0500
> +++ linux006/arch/powerpc/platforms/pseries/lpar.c 2008-06-10 16:48:59.000000000 -0500
> @@ -305,7 +305,8 @@ static long pSeries_lpar_hpte_insert(uns
> flags = 0;
>
> /* Make pHyp happy */
> - if (rflags & (_PAGE_GUARDED|_PAGE_NO_CACHE))
> + if ((rflags & _PAGE_GUARDED) ||
> + ((rflags & _PAGE_NO_CACHE) & !(rflags & _PAGE_WRITETHRU)))
>
I don't think you really meant bitwise AND here. I suppose the second
expression just will never be true.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: linuxppc-dev list <Linuxppc-dev@ozlabs.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC:PATCH 06/06] powerpc: Don't clear _PAGE_COHERENT when _PAGE_SAO is set
Date: Wed, 11 Jun 2008 02:26:14 +0400 [thread overview]
Message-ID: <484EFF86.1030709@ru.mvista.com> (raw)
In-Reply-To: <20080610220129.10257.69024.sendpatchset@norville.austin.ibm.com>
Hello.
Dave Kleikamp wrote:
> powerpc: Don't clear _PAGE_COHERENT when _PAGE_SAO is set
>
> This is a placeholder. Benh tells me that he will come up with a better fix.
>
> Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
> ---
>
> arch/powerpc/platforms/pseries/lpar.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -Nurp linux005/arch/powerpc/platforms/pseries/lpar.c linux006/arch/powerpc/platforms/pseries/lpar.c
> --- linux005/arch/powerpc/platforms/pseries/lpar.c 2008-06-05 10:07:34.000000000 -0500
> +++ linux006/arch/powerpc/platforms/pseries/lpar.c 2008-06-10 16:48:59.000000000 -0500
> @@ -305,7 +305,8 @@ static long pSeries_lpar_hpte_insert(uns
> flags = 0;
>
> /* Make pHyp happy */
> - if (rflags & (_PAGE_GUARDED|_PAGE_NO_CACHE))
> + if ((rflags & _PAGE_GUARDED) ||
> + ((rflags & _PAGE_NO_CACHE) & !(rflags & _PAGE_WRITETHRU)))
>
I don't think you really meant bitwise AND here. I suppose the second
expression just will never be true.
WBR, Sergei
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-10 22:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 22:00 [RFC:PATCH 00/06] Strong Access Ordering page attributes for POWER7 Dave Kleikamp
2008-06-10 22:00 ` Dave Kleikamp
2008-06-10 22:01 ` [RFC:PATCH 01/06] powerpc: hash_huge_page() should get the WIMG bits from the lpte Dave Kleikamp
2008-06-10 22:01 ` Dave Kleikamp
2008-06-10 22:01 ` [RFC:PATCH 02/06] mm: Allow architectures to define additional protection bits Dave Kleikamp
2008-06-10 22:01 ` Dave Kleikamp
2008-06-10 22:14 ` Andrew Morton
2008-06-10 22:14 ` Andrew Morton
2008-06-11 15:47 ` Dave Kleikamp
2008-06-11 15:47 ` Dave Kleikamp
2008-06-10 22:01 ` [RFC:PATCH 03/06] powerpc: Define flags for Strong Access Ordering Dave Kleikamp
2008-06-10 22:01 ` Dave Kleikamp
2008-06-10 22:01 ` [RFC:PATCH 04/06] powerpc: Define CPU_FTR_SAO Dave Kleikamp
2008-06-10 22:01 ` Dave Kleikamp
2008-06-10 22:01 ` [RFC:PATCH 05/06] powerpc: Add Strong Access Ordering Dave Kleikamp
2008-06-10 22:01 ` Dave Kleikamp
2008-06-10 22:01 ` [RFC:PATCH 06/06] powerpc: Don't clear _PAGE_COHERENT when _PAGE_SAO is set Dave Kleikamp
2008-06-10 22:01 ` Dave Kleikamp
2008-06-10 22:26 ` Sergei Shtylyov [this message]
2008-06-10 22:26 ` Sergei Shtylyov
2008-06-11 3:12 ` Dave Kleikamp
2008-06-11 3:12 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484EFF86.1030709@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=Linuxppc-dev@ozlabs.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=shaggy@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.