From: Jeff Garzik <jeff@garzik.org>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: Nicolas 2P <nicolas.2p.debian@free.fr>,
David Miller <davem@davemloft.net>,
bonding-devel@lists.sourceforge.net, linux-net@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [patch] bondig - arp_interval with low value => Oops.
Date: Tue, 10 Jun 2008 18:39:28 -0400 [thread overview]
Message-ID: <484F02A0.7010009@garzik.org> (raw)
In-Reply-To: <8135.1213137006@death>
Jay Vosburgh wrote:
> Jeff Garzik <jeff@garzik.org> wrote:
>
>> Nicolas 2P wrote:
>>> When setting arp_interval parameter to a very low value, delta_in_ticks
>>> for next arp might become 0, causing an infinite loop.
>>>
>>> See http://bugzilla.kernel.org/show_bug.cgi?id=10680
>>>
>>> Same problem for miimon parameter already fixed, but fix might be
>>> enhanced, by using msecs_to_jiffies() function.
>>>
>>> Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
>> I don't see an ACK from Jay in my mbox?
>>
>> Certainly looks nicer than adding "? : 1" to each of the remaining two
>> cases.
>
> This was accepted a couple of weeks ago; I had to fix a bug in
> the patch, so I'd guess you didn't connect them:
>
> commit 5ce0da8f0386b62345312ec8fed31303732f4220
> Author: Jay Vosburgh <fubar@us.ibm.com>
> Date: Sat May 17 21:10:07 2008 -0700
>
> bonding: Use msecs_to_jiffies, eliminate panic
Great, thanks!
prev parent reply other threads:[~2008-06-10 22:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 20:34 [patch] bondig - arp_interval with low value => Oops Nicolas 2P
2008-05-17 20:20 ` Joe Eykholt
2008-05-18 3:39 ` [Bonding-devel] " Jay Vosburgh
2008-06-10 22:19 ` Jeff Garzik
2008-06-10 22:30 ` Jay Vosburgh
2008-06-10 22:39 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484F02A0.7010009@garzik.org \
--to=jeff@garzik.org \
--cc=bonding-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.