From: Jay Vosburgh <fubar@us.ibm.com>
To: Joe Eykholt <jre@nuovasystems.com>
Cc: Nicolas 2P <nicolas.2p.debian@free.fr>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bonding-devel@lists.sourceforge.net, linux-net@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [Bonding-devel] [patch] bondig - arp_interval with low value => Oops.
Date: Sat, 17 May 2008 20:39:20 -0700 [thread overview]
Message-ID: <5888.1211081960@death> (raw)
In-Reply-To: <482F3DF6.7080403@nuovasystems.com>
Joe Eykholt <jre@nuovasystems.com> wrote:
>Nicolas 2P wrote:
[...]
>> @@ -2837,7 +2837,7 @@
>>
>> read_lock(&bond->lock);
>>
>> - delta_in_ticks = (bond->params.arp_interval * HZ) / 1000;
>> + delta_in_ticks = msecs_to_jiffies(bond->params.arp_interval * HZ);
>
>This seems like it should be just:
>
> delta_in_ticks = msecs_to_jiffies(bond->params.arp_interval);
Yes. I've corrected this already in my copy (which I'll be
posting momentarily).
>Same for the other changes?
The other two instances were correct, only the last change had
the extra "* HZ".
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2008-05-18 3:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 20:34 [patch] bondig - arp_interval with low value => Oops Nicolas 2P
2008-05-17 20:20 ` Joe Eykholt
2008-05-18 3:39 ` Jay Vosburgh [this message]
2008-06-10 22:19 ` Jeff Garzik
2008-06-10 22:30 ` Jay Vosburgh
2008-06-10 22:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5888.1211081960@death \
--to=fubar@us.ibm.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=jre@nuovasystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.