iptables 1,4,1 install error

iptables 1,4,1 install error

[michael]

Hello,

Can anyone shed some light on installing iptables1.4.1 on a linux kernel 2.4.34.
make install fails with the following:
Making install in extensions
make[1]: Entering directory `/home/src/iptables-1.4.1/extensions'
install -pm0755 "usr/local/libexec/xtables/";
install: too few arguments
Try `install --help' for more information
make[1]: *** [install] error 1
make[1]: Leaving directory `home/src/iptables-1.4.1/extensions'
make; *** [install-reecursive] Error 1

Thanks,

Michael...

Re: iptables 1,4,1 install error

[Jan Engelhardt]

On Thursday 2008-06-12 07:12, michael wrote:

>Hello,
>
>Can anyone shed some light on installing iptables1.4.1 on a linux kernel 2.4.34.
>make install fails with the following:
>Making install in extensions
>make[1]: Entering directory `/home/src/iptables-1.4.1/extensions'
>install -pm0755 "usr/local/libexec/xtables/";
>install: too few arguments
>Try `install --help' for more information
>make[1]: *** [install] error 1
>make[1]: Leaving directory `home/src/iptables-1.4.1/extensions'
>make; *** [install-reecursive] Error 1
>
>Thanks,
>
>Michael...
>--
>To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

commit f22764c8b9c08abcea002f3c52a8493d3c4ee75f
Author: Jan Engelhardt <jengelh@medozas.de>
Date:   Thu Jun 12 08:43:06 2008 +0200

build: fix `make install` when --disable-shared is used

When --disable-shared is used, there are no .so files to install, and
the argument order for install would get messed up.

Reported-by: Michael Teicher <mteicher@gmail.com>
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>

diff --git a/extensions/GNUmakefile.in b/extensions/GNUmakefile.in
index 8d44e4e..4a3bf4e 100644
--- a/extensions/GNUmakefile.in
+++ b/extensions/GNUmakefile.in
@@ -67,7 +67,7 @@ all: ${targets}
 
 install: ${targets_install}
 	@mkdir -p "${DESTDIR}${xtlibdir}";
-	install -pm0755 $^ "${DESTDIR}${xtlibdir}/";
+	if test -n "${targets_install}"; then install -pm0755 $^ "${DESTDIR}${xtlibdir}/"; fi;
 
 clean:
 	rm -f *.o *.oo *.so *.a {matches,targets}[46].man initext4.c initext6.c;

Re: iptables 1,4,1 install error

[Patrick McHardy]

Jan Engelhardt wrote:
> build: fix `make install` when --disable-shared is used
> 
> When --disable-shared is used, there are no .so files to install, and
> the argument order for install would get messed up.
> 
> Reported-by: Michael Teicher <mteicher@gmail.com>
> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>

Applied, thanks.