Re: [Qemu-devel] [PATCH] New scriptarg=... -net parameter allows passing of an argument

[Avi Kivity <avi@qumranet.com>]

Anthony Liguori wrote:
> Ian Jackson wrote:
>> Previously, network scripts would have to do all of their work based
>> only on the script name and interface name.  If the script's behaviour
>> is supposed to be different for different network interfaces this
>> might involve constructing a special script for each interface with
>> the associated need to delete it etc.
>>   
>
> env args should get passed down to the script although I can see an 
> argument for being able to specify this in -net.  My only suggestion 
> would be to use an env arg instead of "$2" as it will make it easier 
> to extend in the future.

Environment variables are global, whereas scriptarg is per-interface.  
Consider the case where scriptarg denotes the bridge name we want the 
interface to attach to.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.