From: Avi Kivity <avi@qumranet.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] New scriptarg=... -net parameter allows passing of an argument
Date: Fri, 13 Jun 2008 01:04:51 +0300 [thread overview]
Message-ID: <48519D83.6070102@qumranet.com> (raw)
In-Reply-To: <48519A19.8080803@codemonkey.ws>
Anthony Liguori wrote:
>>
>> Environment variables are global, whereas scriptarg is
>> per-interface. Consider the case where scriptarg denotes the bridge
>> name we want the interface to attach to.
>
> Right, what I'm suggesting is that scriptarg=... use an environmental
> variable (for instance, named SCRIPTARG) when executing the actual
> script instead of passing it as the second parameter.
>
> It's nicer IMHO because it extends well to passing more data to the
> script (like whatever the -name parameter is).
Ah, okay. I don't much like environment variables but I do see the
advantages here.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-06-12 22:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 17:25 [Qemu-devel] [PATCH] New scriptarg=... -net parameter allows passing of an argument Ian Jackson
2008-06-12 18:39 ` Anthony Liguori
2008-06-12 21:26 ` Avi Kivity
2008-06-12 21:50 ` Anthony Liguori
2008-06-12 22:04 ` Avi Kivity [this message]
2008-06-13 9:20 ` Ian Jackson
2008-06-13 11:10 ` [Qemu-devel] [PATCH] Pass all parameters to -net tap, ... as env vars to if script Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48519D83.6070102@qumranet.com \
--to=avi@qumranet.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.