[PATCH] kprobes: remove intialization of static per-cpu variable

[PATCH] kprobes: remove intialization of static per-cpu variable

[Vegard Nossum]

From: Vegard Nossum <vegard.nossum@gmail.com>
Date: Thu, 12 Jun 2008 22:02:01 +0200
Subject: [PATCH] kprobes: remove intialization of static per-cpu variable

Cc: Masami Hiramatsu <mhiramat@redhat.com>
Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
---
 kernel/kprobes.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index 1e0250c..04a0c36 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -70,7 +70,7 @@ static bool kprobe_enabled;
 
 DEFINE_MUTEX(kprobe_mutex);		/* Protects kprobe_table */
 DEFINE_SPINLOCK(kretprobe_lock);	/* Protects kretprobe_inst_table */
-static DEFINE_PER_CPU(struct kprobe *, kprobe_instance) = NULL;
+static DEFINE_PER_CPU(struct kprobe *, kprobe_instance);
 
 /*
  * Normally, functions that we'd want to prohibit kprobes in, are marked
-- 
1.5.4.1

Re: [PATCH] kprobes: remove intialization of static per-cpu variable

[Masami Hiramatsu]

Hi Vegard,

Since David who is the sparc kprobes maintainer confirmed this change,
I think it can go.
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>

Vegard Nossum wrote:
> From: Vegard Nossum <vegard.nossum@gmail.com>
> Date: Thu, 12 Jun 2008 22:02:01 +0200
> Subject: [PATCH] kprobes: remove intialization of static per-cpu variable
> 
> Cc: Masami Hiramatsu <mhiramat@redhat.com>
> Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
> ---
>  kernel/kprobes.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index 1e0250c..04a0c36 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -70,7 +70,7 @@ static bool kprobe_enabled;
>  
>  DEFINE_MUTEX(kprobe_mutex);		/* Protects kprobe_table */
>  DEFINE_SPINLOCK(kretprobe_lock);	/* Protects kretprobe_inst_table */
> -static DEFINE_PER_CPU(struct kprobe *, kprobe_instance) = NULL;
> +static DEFINE_PER_CPU(struct kprobe *, kprobe_instance);
>  
>  /*
>   * Normally, functions that we'd want to prohibit kprobes in, are marked

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com