All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Németh Márton" <nm127@freemail.hu>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org, Trivial Patch Monkey <trivial@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] 8139too: different style cleanups
Date: Sat, 14 Jun 2008 14:37:15 +0200	[thread overview]
Message-ID: <4853BB7B.4030905@freemail.hu> (raw)

From: Márton Németh <nm127@freemail.hu>

Clean up the following errors and warnings reported by checkpatch.pl:
 - Use #include <linux/io.h> instead of <asm/io.h>
 - Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
 - __func__ should be used instead of gcc specific __FUNCTION__
 - Macros with complex values should be enclosed in parenthesis
 - do not add new typedefs
 - trailing statements should be on next line
 - braces {} are not necessary for single statement blocks
 - plain inline is preferred over __inline__

Signed-off-by: Márton Németh <nm127@freemail.hu>
---
--- b/drivers/net/8139too.c	2008-06-14 14:08:18.000000000 +0200
+++ c/drivers/net/8139too.c	2008-06-14 14:16:49.000000000 +0200
@@ -107,8 +107,8 @@
 #include <linux/mii.h>
 #include <linux/completion.h>
 #include <linux/crc32.h>
-#include <asm/io.h>
-#include <asm/uaccess.h>
+#include <linux/io.h>
+#include <linux/uaccess.h>
 #include <asm/irq.h>

 #define RTL8139_DRIVER_NAME   DRV_NAME " Fast Ethernet driver " DRV_VERSION
@@ -135,7 +135,7 @@
 #if RTL8139_DEBUG
 /* note: prints function name for you */
 #  define DPRINTK(fmt, args...) \
-	printk(KERN_DEBUG "%s: " fmt, __FUNCTION__ , ## args)
+	printk(KERN_DEBUG "%s: " fmt, __func__ , ## args)
 #else
 #  define DPRINTK(fmt, args...)
 #endif
@@ -146,7 +146,7 @@
 #  define assert(expr) \
 	if (unlikely(!(expr))) {					\
 		printk(KERN_ERR "Assertion failed! %s,%s,%s,line=%d\n",	\
-		       #expr, __FILE__, __FUNCTION__, __LINE__);	\
+		       #expr, __FILE__, __func__, __LINE__);	\
 	}
 #endif

@@ -221,9 +221,9 @@ enum {
 #define RTL8139B_IO_SIZE 256

 #define RTL8129_CAPS	HAS_MII_XCVR
-#define RTL8139_CAPS	HAS_CHIP_XCVR|HAS_LNK_CHNG
+#define RTL8139_CAPS	(HAS_CHIP_XCVR|HAS_LNK_CHNG)

-typedef enum {
+enum {
 	RTL8139 = 0,
 	RTL8129,
 } board_t;
@@ -1033,7 +1033,8 @@ static int __devinit rtl8139_init_one(st
 	/* dev is fully set up and ready to use now */
 	DPRINTK("about to register device named %s (%p)...\n", dev->name, dev);
 	i = register_netdev(dev);
-	if (i) goto err_out;
+	if (i)
+		goto err_out;

 	pci_set_drvdata(pdev, dev);

@@ -1378,9 +1379,9 @@ static void rtl_check_media(struct net_d
 {
 	struct rtl8139_private *tp = netdev_priv(dev);

-	if (tp->phys[0] >= 0) {
+	if (tp->phys[0] >= 0)
 		mii_check_media(&tp->mii, netif_msg_link(tp), init_media);
-	}
+
 }

 /* Start the hardware at open or resume. */
@@ -1921,7 +1922,7 @@ static void rtl8139_rx_err(u32 rx_status
 }

 #if RX_BUF_IDX == 3
-static __inline__ void wrap_copy(struct sk_buff *skb, const unsigned char *ring,
+static inline void wrap_copy(struct sk_buff *skb, const unsigned char *ring,
 				 u32 offset, unsigned int size)
 {
 	u32 left = RX_BUF_LEN - offset;


             reply	other threads:[~2008-06-14 12:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-14 12:37 Németh Márton [this message]
2008-06-14 18:44 ` [PATCH 2/2] 8139too: different style cleanups Németh Márton
2008-06-15  6:26   ` David Newall
2008-06-15  6:50     ` Harvey Harrison
2008-06-16  5:09     ` [PATCH] 8139too: add missing brackets Németh Márton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4853BB7B.4030905@freemail.hu \
    --to=nm127@freemail.hu \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.