From: "Németh Márton" <nm127@freemail.hu>
To: David Newall <davidn@davidnewall.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
netdev@vger.kernel.org, Trivial Patch Monkey <trivial@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] 8139too: add missing brackets
Date: Mon, 16 Jun 2008 07:09:56 +0200 [thread overview]
Message-ID: <4855F5A4.4020109@freemail.hu> (raw)
In-Reply-To: <4854B604.6080900@davidnewall.com>
From: Márton Németh <nm127@freemail.hu>
Clean up the following error reported by checkpatch.pl:
- Macros with complex values should be enclosed in parenthesis
The macro RTL8139_CAPS currently only used as a whole expression
to initialize board_info[] so this change won't change the resulting code.
Signed-off-by: Márton Németh <nm127@freemail.hu>
---
--- a/drivers/net/8139too.c 2008-06-14 00:20:47.000000000 +0200
+++ b/drivers/net/8139too.c 2008-06-16 07:03:20.000000000 +0200
@@ -219,7 +219,7 @@ enum {
#define RTL8139B_IO_SIZE 256
#define RTL8129_CAPS HAS_MII_XCVR
-#define RTL8139_CAPS HAS_CHIP_XCVR|HAS_LNK_CHNG
+#define RTL8139_CAPS (HAS_CHIP_XCVR|HAS_LNK_CHNG)
typedef enum {
RTL8139 = 0,
prev parent reply other threads:[~2008-06-16 5:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-14 12:37 [PATCH 2/2] 8139too: different style cleanups Németh Márton
2008-06-14 18:44 ` Németh Márton
2008-06-15 6:26 ` David Newall
2008-06-15 6:50 ` Harvey Harrison
2008-06-16 5:09 ` Németh Márton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4855F5A4.4020109@freemail.hu \
--to=nm127@freemail.hu \
--cc=davidn@davidnewall.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.