All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: ALSA-devel <alsa-devel@alsa-project.org>
Subject: Re: Thoughts on ASOC v2 driver architecture
Date: Mon, 16 Jun 2008 10:34:42 -0500	[thread overview]
Message-ID: <48568812.5020101@freescale.com> (raw)
In-Reply-To: <9e4733910806160732h2b1b42f3s1afde73ac8f92026@mail.gmail.com>

Jon Smirl wrote:

> I think I've come up with a solution. Push all of that generic setup
> code in mpc8610_hpcd into fsl_ssi.

I would NACK a patch that did that, if you were to submit it here.

> Leave only the platform specific
> support in mpc8610_hpcd. Now turn mpc8610_hpcd into a loadable module
> but leave it as a platform_driver. During the fsl_ssi probe function
> extract the platform name from the device tree and use it to
> dynamically load the mpc8610_hpcd driver.

If you want to augment the drivers to get more information from the device tree,
like names, I would be okay with that.  But I don't like moving any fabric
functionality from the fabric driver into another driver.  The SSI driver cannot
ever be aware of more than one SSI at a time.

-- 
Timur Tabi
Linux kernel developer at Freescale

  parent reply	other threads:[~2008-06-16 15:34 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-15 18:10 Thoughts on ASOC v2 driver architecture Jon Smirl
2008-06-16 10:39 ` Liam Girdwood
2008-06-16 13:26   ` Jon Smirl
2008-06-16 14:23     ` Timur Tabi
2008-06-16 14:32       ` Jon Smirl
2008-06-16 15:03         ` Mark Brown
2008-06-16 15:36           ` Timur Tabi
2008-06-16 15:45             ` Mark Brown
2008-06-16 15:49               ` Timur Tabi
2008-06-16 17:03                 ` Mark Brown
2008-06-16 17:10                   ` Timur Tabi
2008-06-16 15:53           ` Jon Smirl
2008-06-16 16:01             ` Timur Tabi
2008-06-16 16:23               ` Jon Smirl
2008-06-16 16:24                 ` Timur Tabi
2008-06-17  0:58                   ` Jon Smirl
2008-06-17 14:55                     ` Timur Tabi
2008-06-16 16:11             ` Jon Smirl
2008-06-16 16:58               ` Mark Brown
2008-06-16 17:00                 ` Timur Tabi
2008-06-16 16:24             ` Mark Brown
2008-06-16 15:34         ` Timur Tabi [this message]
2008-06-16 13:47   ` Jon Smirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48568812.5020101@freescale.com \
    --to=timur@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jonsmirl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.