Re: Thoughts on ASOC v2 driver architecture

[Timur Tabi <timur@freescale.com>]

Jon Smirl wrote:

> The driver stays in sound/soc/fsl. It's only the creation of the
> device that moves. You just need to add this to
> arch/powerpc/platforms/86xx/mpc8610_hpcd.c and remove it from
> mpc8610_hpcd.c. Adding this to
> arch/powerpc/platforms/86xx/mpc8610_hpcd.c will have no effect if the
> mpc8610_hpcd.c driver is not to be found.

Ok, I'll do that.

> You've complicated it by creating two fabric devices but I believe
> your code could be changed to only make one.
> 
> static struct platform_device alsa_fabric = {
> 	.name		= "MPC8610HPCD",
> 	.id		= -1,
> };
> 
> static struct platform_device *devices[] = {
> 	&alsa_fabric,
> };
> 
> platform_add_devices(&devices[0], ARRAY_SIZE(devices));
> 
> 
> I'd rename the driver to something less generic.
> 	.name		= "MPC8610HPCD-fabric",

These are all good ideas.  Thanks.

-- 
Timur Tabi
Linux kernel developer at Freescale