From: Pavel Emelyanov <xemul@openvz.org>
To: Vlad Yasevich <vladislav.yasevich@hp.com>,
David Miller <davem@davemloft.net>
Cc: linux-sctp@vger.kernel.org, Linux Netdev List <netdev@vger.kernel.org>
Subject: [PATCH] sctp: fix error path in sctp_proc_init
Date: Tue, 17 Jun 2008 12:29:13 +0000 [thread overview]
Message-ID: <4857AE19.9050708@openvz.org> (raw)
After the sctp_remaddr_proc_init failed, the proper rollback is
not the sctp_remaddr_proc_exit, but the sctp_assocs_proc_exit.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
index 23aaffb..98c6a88 100644
--- a/net/sctp/protocol.c
+++ b/net/sctp/protocol.c
@@ -119,7 +119,7 @@ static __init int sctp_proc_init(void)
return 0;
out_remaddr_proc_init:
- sctp_remaddr_proc_exit();
+ sctp_assocs_proc_exit();
out_assocs_proc_init:
sctp_eps_proc_exit();
out_eps_proc_init:
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Emelyanov <xemul@openvz.org>
To: Vlad Yasevich <vladislav.yasevich@hp.com>,
David Miller <davem@davemloft.net>
Cc: linux-sctp@vger.kernel.org, Linux Netdev List <netdev@vger.kernel.org>
Subject: [PATCH] sctp: fix error path in sctp_proc_init
Date: Tue, 17 Jun 2008 16:29:13 +0400 [thread overview]
Message-ID: <4857AE19.9050708@openvz.org> (raw)
After the sctp_remaddr_proc_init failed, the proper rollback is
not the sctp_remaddr_proc_exit, but the sctp_assocs_proc_exit.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
index 23aaffb..98c6a88 100644
--- a/net/sctp/protocol.c
+++ b/net/sctp/protocol.c
@@ -119,7 +119,7 @@ static __init int sctp_proc_init(void)
return 0;
out_remaddr_proc_init:
- sctp_remaddr_proc_exit();
+ sctp_assocs_proc_exit();
out_assocs_proc_init:
sctp_eps_proc_exit();
out_eps_proc_init:
next reply other threads:[~2008-06-17 12:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 12:29 Pavel Emelyanov [this message]
2008-06-17 12:29 ` [PATCH] sctp: fix error path in sctp_proc_init Pavel Emelyanov
2008-06-17 12:29 ` Pavel Emelyanov
2008-06-17 12:29 ` Pavel Emelyanov
2008-06-17 13:46 ` Vlad Yasevich
2008-06-17 13:46 ` Vlad Yasevich
2008-06-17 21:41 ` David Miller
2008-06-17 21:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4857AE19.9050708@openvz.org \
--to=xemul@openvz.org \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.