All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes
Date: Tue, 19 Dec 2023 10:13:03 +0100	[thread overview]
Message-ID: <4858990.GXAFRqVoOG@steina-w> (raw)
In-Reply-To: <b01e05ac-8b28-49ad-8a1e-9cd667e5f1ec@lunn.ch>

Hi Andrew,

Am Dienstag, 19. Dezember 2023, 10:09:24 CET schrieb Andrew Lunn:
> On Tue, Dec 19, 2023 at 10:02:48AM +0100, Alexander Stein wrote:
> > Devicetree spec lists only dashes as valid characters for alias names.
> > Table 3.2: Valid characters for alias names, Devicee Specification,
> > Release v0.4
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > 
> >  drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> > b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c index
> > e625b32889bf..0928a526e2ab 100644
> > --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> > +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> > @@ -706,7 +706,7 @@ static int mixel_dphy_probe(struct platform_device
> > *pdev)> 
> >  			return ret;
> >  		
> >  		}
> > 
> > -		priv->id = of_alias_get_id(np, "mipi_dphy");
> > +		priv->id = of_alias_get_id(np, "mipi-dphy");
> 
> Are there any in tree DT blobs using mipi_dphy which are going to
> break because of this change?

You are right, I should have mentioned that already.
The alias is only used when used on a combo-PHY, which is only i.MX8QXP. Up 
until now there is no DT node in-kernel which uses the fsl,imx8qxp-mipi-dphy 
compatible. So no there should be no blobs at all using the old alias name.

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes
Date: Tue, 19 Dec 2023 10:13:03 +0100	[thread overview]
Message-ID: <4858990.GXAFRqVoOG@steina-w> (raw)
In-Reply-To: <b01e05ac-8b28-49ad-8a1e-9cd667e5f1ec@lunn.ch>

Hi Andrew,

Am Dienstag, 19. Dezember 2023, 10:09:24 CET schrieb Andrew Lunn:
> On Tue, Dec 19, 2023 at 10:02:48AM +0100, Alexander Stein wrote:
> > Devicetree spec lists only dashes as valid characters for alias names.
> > Table 3.2: Valid characters for alias names, Devicee Specification,
> > Release v0.4
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > 
> >  drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> > b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c index
> > e625b32889bf..0928a526e2ab 100644
> > --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> > +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> > @@ -706,7 +706,7 @@ static int mixel_dphy_probe(struct platform_device
> > *pdev)> 
> >  			return ret;
> >  		
> >  		}
> > 
> > -		priv->id = of_alias_get_id(np, "mipi_dphy");
> > +		priv->id = of_alias_get_id(np, "mipi-dphy");
> 
> Are there any in tree DT blobs using mipi_dphy which are going to
> break because of this change?

You are right, I should have mentioned that already.
The alias is only used when used on a combo-PHY, which is only i.MX8QXP. Up 
until now there is no DT node in-kernel which uses the fsl,imx8qxp-mipi-dphy 
compatible. So no there should be no blobs at all using the old alias name.

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-12-19  9:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19  9:02 [PATCH 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes Alexander Stein
2023-12-19  9:02 ` Alexander Stein
2023-12-19  9:09 ` Andrew Lunn
2023-12-19  9:09   ` Andrew Lunn
2023-12-19  9:13   ` Alexander Stein [this message]
2023-12-19  9:13     ` Alexander Stein
2023-12-19 11:59     ` Vladimir Oltean
2023-12-19 11:59       ` Vladimir Oltean
2023-12-20  2:27 ` Ying Liu
2023-12-20  2:27   ` Ying Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4858990.GXAFRqVoOG@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=andrew@lunn.ch \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kishon@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-phy@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.