From: Avi Kivity <avi@qumranet.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH] make qemu compile for kvm/ia64
Date: Wed, 18 Jun 2008 13:42:02 +0000 [thread overview]
Message-ID: <485910AA.3070705@qumranet.com> (raw)
In-Reply-To: <51CFAB8CB6883745AE7B93B3E084EBE201D2C4F2@pdsmsx412.ccr.corp.intel.com>
Xu, Anthony wrote:
> From 7b2c2612b21b895cd14e632fea845c03b6e1dedc Mon Sep 17 00:00:00 2001
> From: Anthony Xu <anthony.xu@intel.com>
> Date: Thu, 29 May 2008 13:14:56 -0400
> Subject: [PATCH] Make qemu compile for kvm-ia64
>
> Since merging with Qemu upsteram, it can't be compiled
> for kvm-ia64
>
> @@ -620,7 +622,10 @@ int cpu_exec(CPUState *env1)
> env = cpu_single_env;
> #define env cpu_single_env
> #endif
> +
> +#if !defined(TARGET_IA64)
> next_tb = tcg_qemu_tb_exec(tc_ptr);
> +#endif
>
Instead of sprinkling all those ifdefs, how about proving stubs
instead? It will reduce the merge overhead, and will be easier to fix
if/when tcg can target ia64.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@qumranet.com>
To: "Xu, Anthony" <anthony.xu@intel.com>
Cc: kvm@vger.kernel.org, kvm-ia64@vger.kernel.org
Subject: Re: [PATCH] make qemu compile for kvm/ia64
Date: Wed, 18 Jun 2008 06:42:02 -0700 [thread overview]
Message-ID: <485910AA.3070705@qumranet.com> (raw)
In-Reply-To: <51CFAB8CB6883745AE7B93B3E084EBE201D2C4F2@pdsmsx412.ccr.corp.intel.com>
Xu, Anthony wrote:
> From 7b2c2612b21b895cd14e632fea845c03b6e1dedc Mon Sep 17 00:00:00 2001
> From: Anthony Xu <anthony.xu@intel.com>
> Date: Thu, 29 May 2008 13:14:56 -0400
> Subject: [PATCH] Make qemu compile for kvm-ia64
>
> Since merging with Qemu upsteram, it can't be compiled
> for kvm-ia64
>
> @@ -620,7 +622,10 @@ int cpu_exec(CPUState *env1)
> env = cpu_single_env;
> #define env cpu_single_env
> #endif
> +
> +#if !defined(TARGET_IA64)
> next_tb = tcg_qemu_tb_exec(tc_ptr);
> +#endif
>
Instead of sprinkling all those ifdefs, how about proving stubs
instead? It will reduce the merge overhead, and will be easier to fix
if/when tcg can target ia64.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-06-18 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-18 5:41 [PATCH] make qemu compile for kvm/ia64 Xu, Anthony
2008-06-18 5:41 ` Xu, Anthony
2008-06-18 13:42 ` Avi Kivity [this message]
2008-06-18 13:42 ` Avi Kivity
2008-06-20 2:55 ` Xu, Anthony
2008-06-20 2:55 ` Xu, Anthony
2008-06-25 11:43 ` Avi Kivity
2008-06-25 11:43 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485910AA.3070705@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.