All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Ingo Molnar <mingo@redhat.com>,
	tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Andi Kleen <andi@firstfloor.org>,
	the arch/x86 maintainers <x86@kernel.org>,
	Mike Travis <travis@sgi.com>
Subject: Re: [PATCH 1/1] MM: virtual address debug
Date: Wed, 18 Jun 2008 16:11:37 +0200	[thread overview]
Message-ID: <48591799.6050508@gmail.com> (raw)
In-Reply-To: <20080618135928.GA12803@elte.hu>

Ingo Molnar napsal(a):
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
>> * Jiri Slaby <jirislaby@gmail.com> wrote:
>>
>>> Add some (configurable) expensive sanity checking to catch wrong address
>>> translations on x86.
>>>
>>> - create linux/mmdebug.h file to be able include this file in
>>>   asm headers to not get unsolvable loops in header files
>>> - __phys_addr on x86_32 became a function in ioremap.c since
>>>   PAGE_OFFSET, is_vmalloc_addr and VMALLOC_* non-constasts are undefined
>>>   if declared in page_32.h
>>> - add __phys_addr_const for initializing doublefault_tss.__cr3
>> applied, thanks Jiri. I have created a new tip/x86/mm-debug topic for 
>> this because the patch touches mm/vmalloc.c and other MM bits.
> 
> -tip testing triggered an early boot crash and i have bisected it down 
> to your patch. The crash:
> 
> No NUMA configuration found
> Faking a node at 0000000000000000-000000003fff0000
> Entering add_active_range(0, 0, 159) 0 entries of 25600 used
> Entering add_active_range(0, 256, 262128) 1 entries of 25600 used
> Bootmem setup node 0 0000000000000000-000000003fff0000
>   NODE_DATA [000000000000a000 - 000000000003dfff]
> PANIC: early exception 06 rip 10:ffffffff80ba7531 error 0 cr2 f06f53

Expception 06 is an invalid opcode. This is maybe a false positive, probably 
a mistake in phys_to_nid, I'll look into that, thanks.

> Pid: 0, comm: swapper Not tainted 2.6.26-rc6 #7709
> 
> Call Trace:
>  [<ffffffff80b9c196>] early_idt_handler+0x56/0x6a
>  [<ffffffff80ba7531>] setup_node_bootmem+0x12a/0x2d4
>  [<ffffffff80ba7505>] setup_node_bootmem+0xfe/0x2d4
>  [<ffffffff80b9dd73>] setup_arch+0x2a2/0x3e7
>  [<ffffffff8024e858>] clockevents_register_notifier+0x2d/0x31
>  [<ffffffff80b9cb5d>] start_kernel+0x8d/0x30a
>  [<ffffffff80b9f87d>] reserve_early+0x16/0xad
>  [<ffffffff80b9c35f>] x86_64_start_kernel+0x16d/0x174
> 
> RIP 0x10

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Ingo Molnar <mingo@redhat.com>,
	tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Andi Kleen <andi@firstfloor.org>,
	the arch/x86 maintainers <x86@kernel.org>,
	Mike Travis <travis@sgi.com>
Subject: Re: [PATCH 1/1] MM: virtual address debug
Date: Wed, 18 Jun 2008 16:11:37 +0200	[thread overview]
Message-ID: <48591799.6050508@gmail.com> (raw)
In-Reply-To: <20080618135928.GA12803@elte.hu>

Ingo Molnar napsal(a):
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
>> * Jiri Slaby <jirislaby@gmail.com> wrote:
>>
>>> Add some (configurable) expensive sanity checking to catch wrong address
>>> translations on x86.
>>>
>>> - create linux/mmdebug.h file to be able include this file in
>>>   asm headers to not get unsolvable loops in header files
>>> - __phys_addr on x86_32 became a function in ioremap.c since
>>>   PAGE_OFFSET, is_vmalloc_addr and VMALLOC_* non-constasts are undefined
>>>   if declared in page_32.h
>>> - add __phys_addr_const for initializing doublefault_tss.__cr3
>> applied, thanks Jiri. I have created a new tip/x86/mm-debug topic for 
>> this because the patch touches mm/vmalloc.c and other MM bits.
> 
> -tip testing triggered an early boot crash and i have bisected it down 
> to your patch. The crash:
> 
> No NUMA configuration found
> Faking a node at 0000000000000000-000000003fff0000
> Entering add_active_range(0, 0, 159) 0 entries of 25600 used
> Entering add_active_range(0, 256, 262128) 1 entries of 25600 used
> Bootmem setup node 0 0000000000000000-000000003fff0000
>   NODE_DATA [000000000000a000 - 000000000003dfff]
> PANIC: early exception 06 rip 10:ffffffff80ba7531 error 0 cr2 f06f53

Expception 06 is an invalid opcode. This is maybe a false positive, probably 
a mistake in phys_to_nid, I'll look into that, thanks.

> Pid: 0, comm: swapper Not tainted 2.6.26-rc6 #7709
> 
> Call Trace:
>  [<ffffffff80b9c196>] early_idt_handler+0x56/0x6a
>  [<ffffffff80ba7531>] setup_node_bootmem+0x12a/0x2d4
>  [<ffffffff80ba7505>] setup_node_bootmem+0xfe/0x2d4
>  [<ffffffff80b9dd73>] setup_arch+0x2a2/0x3e7
>  [<ffffffff8024e858>] clockevents_register_notifier+0x2d/0x31
>  [<ffffffff80b9cb5d>] start_kernel+0x8d/0x30a
>  [<ffffffff80b9f87d>] reserve_early+0x16/0xad
>  [<ffffffff80b9c35f>] x86_64_start_kernel+0x16d/0x174
> 
> RIP 0x10

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-06-18 14:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12 11:56 [PATCH 1/1] MM: virtual address debug Jiri Slaby
2008-06-12 11:56 ` Jiri Slaby
2008-06-18 12:12 ` Ingo Molnar
2008-06-18 12:12   ` Ingo Molnar
2008-06-18 13:59   ` Ingo Molnar
2008-06-18 13:59     ` Ingo Molnar
2008-06-18 14:11     ` Jiri Slaby [this message]
2008-06-18 14:11       ` Jiri Slaby
2008-06-18 16:11     ` Jiri Slaby
2008-06-18 16:11       ` Jiri Slaby
2008-06-18 18:35     ` [PATCH v2] " Jiri Slaby
2008-06-18 18:35       ` Jiri Slaby
2008-06-19 11:34       ` Ingo Molnar
2008-06-19 11:34         ` Ingo Molnar
2008-06-18 12:51 ` [PATCH 1/1] " Nick Piggin
2008-06-18 12:51   ` Nick Piggin
2008-06-18 13:41   ` Jiri Slaby
2008-06-18 13:41     ` Jiri Slaby
2008-06-18 14:01     ` Nick Piggin
2008-06-18 14:01       ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48591799.6050508@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=travis@sgi.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.