[ULOGD1 PATCH] Fix PCAP len (Jaap Keuter)

[ULOGD1 PATCH] Fix PCAP len (Jaap Keuter)

[Eric Leblond]

This is a application of patch provided by Jaap Keuter. Application will close
bugzilla 535. pcap len was set to value of the pointer to raw data.

Signed-off-by: Eric Leblond <eric@inl.fr>
---
 pcap/ulogd_PCAP.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/pcap/ulogd_PCAP.c b/pcap/ulogd_PCAP.c
index 686fe47..7d67c28 100644
--- a/pcap/ulogd_PCAP.c
+++ b/pcap/ulogd_PCAP.c
@@ -131,7 +131,7 @@ static int pcap_output(ulog_iret_t *res)
 {
 	struct pcap_sf_pkthdr pchdr;
 
-	pchdr.caplen = GET_VALUE(1).ui32;
+	pchdr.caplen = GET_VALUE(2).ui32;
 	pchdr.len = GET_VALUE(2).ui32;
 
 	if (GET_FLAGS(3) & ULOGD_RETF_VALID
-- 
1.5.5.3

Re: [ULOGD1 PATCH] Fix PCAP len (Jaap Keuter)

[Pablo Neira Ayuso]

Eric Leblond wrote:
> This is a application of patch provided by Jaap Keuter. Application will close
> bugzilla 535. pcap len was set to value of the pointer to raw data.

Applied. Thanks Eric.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers

Re: [ULOGD1 PATCH] Fix PCAP len (Jaap Keuter)

[Patrick McHardy]

Pablo Neira Ayuso wrote:
> Eric Leblond wrote:
>> This is a application of patch provided by Jaap Keuter. Application will close
>> bugzilla 535. pcap len was set to value of the pointer to raw data.
> 
> Applied. Thanks Eric.

BTW, did we actually release a new ulogd with the SuSE-fixes
from .. about a year ago?

Re: [ULOGD1 PATCH] Fix PCAP len (Jaap Keuter)

[Pablo Neira Ayuso]

Patrick McHardy wrote:
> Pablo Neira Ayuso wrote:
>> Eric Leblond wrote:
>>> This is a application of patch provided by Jaap Keuter. Application
>>> will close
>>> bugzilla 535. pcap len was set to value of the pointer to raw data.
>>
>> Applied. Thanks Eric.
> 
> BTW, did we actually release a new ulogd with the SuSE-fixes
> from .. about a year ago?

Indeed, I'll prepare two releases, one of ulogdv1 and development
version of ulogdv2.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers

Re: [ULOGD1 PATCH] Fix PCAP len (Jaap Keuter)

[Patrick McHardy]

Pablo Neira Ayuso wrote:
> Patrick McHardy wrote:
>> Pablo Neira Ayuso wrote:
>>> Eric Leblond wrote:
>>>> This is a application of patch provided by Jaap Keuter. Application
>>>> will close
>>>> bugzilla 535. pcap len was set to value of the pointer to raw data.
>>> Applied. Thanks Eric.
>> BTW, did we actually release a new ulogd with the SuSE-fixes
>> from .. about a year ago?
> 
> Indeed, I'll prepare two releases, one of ulogdv1 and development
> version of ulogdv2.

Great, its really time for a ulogd2 beta.

Re: [ULOGD1 PATCH] Fix PCAP len (Jaap Keuter)

[Eric Leblond]

Hello,

On Wednesday, 2008 June 18 at 17:25:13 +0200, Patrick McHardy wrote:
> Pablo Neira Ayuso wrote:
>> Patrick McHardy wrote:
>>>>> will close
>>>>> bugzilla 535. pcap len was set to value of the pointer to raw data.
>>>> Applied. Thanks Eric.
>>> BTW, did we actually release a new ulogd with the SuSE-fixes
>>> from .. about a year ago?
>>
>> Indeed, I'll prepare two releases, one of ulogdv1 and development
>> version of ulogdv2.
>
> Great, its really time for a ulogd2 beta.

Pierre and I have just found a bug on mac address handling. I will fix
this and send you the patch (should be tonight). My test system was
INPUT, OUTPUT only and switching to a FORWARD one reveal some problems.

BR,
-- 
Eric Leblond
INL: http://www.inl.fr/
NuFW: http://www.nufw.org/