* [U-Boot-Users] [PATCH] fix system config overwrite @ MPC834x and MPC8313
@ 2008-06-23 9:40 Andre Schwarz
2008-06-25 22:12 ` Kim Phillips
0 siblings, 1 reply; 2+ messages in thread
From: Andre Schwarz @ 2008-06-23 9:40 UTC (permalink / raw)
To: u-boot
During 83xx setup the "System I/O configuration register high" gets
overwritten with user defined value if CFG_SICRH is defined.
Regarding to the MPC834x manual (Table 5-28 reve.1) bits 28+29 of SICRH
must keep their reset value regardless of configuration.
On my board (using RGMII) those bits are set after reset - yet it's
unclear where they come from.
The patch keeps both bits on MPC834x and MPC8313.
Signed-off-by: Andre Schwarz <andre.schwarz@matrix-vision.de>
---
MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090
Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch_mpc834x_sicrh
Url: http://lists.denx.de/pipermail/u-boot/attachments/20080623/6863bc9e/attachment.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot-Users] [PATCH] fix system config overwrite @ MPC834x and MPC8313
2008-06-23 9:40 [U-Boot-Users] [PATCH] fix system config overwrite @ MPC834x and MPC8313 Andre Schwarz
@ 2008-06-25 22:12 ` Kim Phillips
0 siblings, 0 replies; 2+ messages in thread
From: Kim Phillips @ 2008-06-25 22:12 UTC (permalink / raw)
To: u-boot
On Mon, 23 Jun 2008 11:40:56 +0200
Andre Schwarz <andre.schwarz@matrix-vision.de> wrote:
> During 83xx setup the "System I/O configuration register high" gets
> overwritten with user defined value if CFG_SICRH is defined.
>
> Regarding to the MPC834x manual (Table 5-28 reve.1) bits 28+29 of SICRH
> must keep their reset value regardless of configuration.
>
> On my board (using RGMII) those bits are set after reset - yet it's
> unclear where they come from.
>
> The patch keeps both bits on MPC834x and MPC8313.
>
> Signed-off-by: Andre Schwarz <andre.schwarz@matrix-vision.de>
this has been applied after a slight rewrite to not cause the following:
cpu_init.c: In function ?cpu_init_f?:
cpu_init.c:62: warning: unused variable ?tmp_sicrh?
Thanks Andre,
Kim
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-25 22:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-23 9:40 [U-Boot-Users] [PATCH] fix system config overwrite @ MPC834x and MPC8313 Andre Schwarz
2008-06-25 22:12 ` Kim Phillips
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.