From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Leblond <eric@inl.fr>
Cc: netfilter-devel@vger.kernel.org, chifflier@inl.fr
Subject: Re: [ULOGD PATCH 4/6] Introduce datatype and hwaddrlen param to MAC2STR plugin.
Date: Mon, 23 Jun 2008 16:42:50 +0200 [thread overview]
Message-ID: <485FB66A.1090601@netfilter.org> (raw)
In-Reply-To: <1213878187-909-5-git-send-email-eric@inl.fr>
Eric Leblond wrote:
> This patch introduces a hwaddrlen and datatype parameters in
> MAC2STR configuration. This is a workaround differences between
> ULOG and NFLOG:
> * NFLOG sends MAC address in userspace (dev_parse_header content)
> * ULOG sends complete link header (skb_mac_header content)
> And they use the same field (raw.mac) for that. Database schema
> needs mac.saddr.str and/or mac.daddr.str fields. With datatype set
> 0 only mac.daddr is logged. Both fields are filled when datatype is
> set to 1.
Why not split KEY_RAW_MAC into two keys in the input plugins, eg.
KEY_RAW_SMAC and KEY_RAW_DMAC? Thus, we inconditionally dump the source
and the destination MAC if they are present.
I'm not a big fun of adding options that can confuse users.
--
"Los honestos son inadaptados sociales" -- Les Luthiers
next prev parent reply other threads:[~2008-06-23 14:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 12:23 [ULOGD PATCH 0/6] Fix difference between ULOG and NFLOG Eric Leblond
2008-06-19 12:23 ` [ULOGD PATCH 1/6] Suppress spaces at end of line Eric Leblond
2008-06-23 14:23 ` Pablo Neira Ayuso
2008-06-19 12:23 ` [ULOGD PATCH 2/6] Convert struct to [KEY] = {} format Eric Leblond
2008-06-23 14:23 ` Pablo Neira Ayuso
2008-06-19 12:23 ` [ULOGD PATCH 3/6] Fix warning about unused variable if NFLOG_GID is not available Eric Leblond
2008-06-23 14:25 ` Pablo Neira Ayuso
2008-06-27 19:41 ` Eric Leblond
2008-06-27 20:29 ` Eric Leblond
2008-06-28 9:54 ` Pablo Neira Ayuso
2008-06-28 10:25 ` Eric Leblond
2008-06-28 10:45 ` Pablo Neira Ayuso
2008-06-28 10:45 ` Pablo Neira Ayuso
2008-06-19 12:23 ` [ULOGD PATCH 4/6] Introduce datatype and hwaddrlen param to MAC2STR plugin Eric Leblond
2008-06-23 14:42 ` Pablo Neira Ayuso [this message]
2008-06-27 23:02 ` [ULOGD PATCH 0/6] rework mac address related issues Eric Leblond
2008-06-27 23:02 ` [ULOGD PATCH 1/6] Specify that NFLOG only return mac saddr Eric Leblond
2008-06-27 23:02 ` [ULOGD PATCH 2/6] Adapt MAC2STR to NFLOG and ULOG input key change Eric Leblond
2008-06-27 23:02 ` [ULOGD PATCH 3/6] Output mac.saddr and mac.daddr in ULOG plugin Eric Leblond
2008-07-02 13:52 ` [ULOGD PATCH] Output mac.saddr, mac.daddr and oob.protocol " Eric Leblond
2008-07-02 13:56 ` Patrick McHardy
2008-07-08 21:56 ` [ULOGD PATCH] rework, fill MAC address in ULOG for ethernet Eric Leblond
2008-07-09 10:50 ` Pablo Neira Ayuso
2008-07-09 10:53 ` Patrick McHardy
2008-07-09 11:03 ` Pablo Neira Ayuso
2008-07-09 11:10 ` Patrick McHardy
2008-07-09 21:04 ` Eric Leblond
2008-07-09 21:18 ` Patrick McHardy
2008-07-10 20:39 ` Eric Leblond
2008-07-11 14:08 ` Patrick McHardy
2008-07-15 12:49 ` Eric Leblond
2008-07-15 13:26 ` Patrick McHardy
2008-07-16 22:24 ` netfilter: Send complete hardware header in NFLOG Eric Leblond
2008-07-17 9:01 ` Patrick McHardy
2008-07-17 9:12 ` Eric Leblond
2008-07-17 9:14 ` Patrick McHardy
2008-07-16 22:29 ` [libnetfilter_log PATCH] Add parsing function for raw hardware header Eric Leblond
2008-07-17 9:13 ` Patrick McHardy
2008-07-16 22:31 ` [ULOGD2 PATCH] Sync NFLOG input plugin with NFLOG modification related to " Eric Leblond
2008-07-20 23:51 ` Pablo Neira Ayuso
2008-06-27 23:02 ` [ULOGD PATCH 4/6] Parse oob protocol in ULOG when possible Eric Leblond
2008-06-27 23:02 ` [ULOGD PATCH 5/6] Add destination mac_addr to database Eric Leblond
2008-06-27 23:03 ` [ULOGD PATCH 6/6] Sync PRINTPKT with mac modification Eric Leblond
2008-06-19 12:23 ` [ULOGD PATCH 5/6] Add destination mac_addr to database Eric Leblond
2008-06-23 14:44 ` Pablo Neira Ayuso
2008-06-19 12:23 ` [ULOGD PATCH 6/6] Suppress verbose debug message in ULOG Eric Leblond
2008-06-23 14:46 ` Pablo Neira Ayuso
2008-06-19 12:25 ` netfilter: Make NFLOG dump all hardware header Eric Leblond
2008-06-19 12:30 ` Patrick McHardy
2008-06-19 12:55 ` [PATCH] Change packet hw header struct accordingly to NFLOG update Eric Leblond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485FB66A.1090601@netfilter.org \
--to=pablo@netfilter.org \
--cc=chifflier@inl.fr \
--cc=eric@inl.fr \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.