From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: "Elaine Zhang" <zhangqing@rock-chips.com>,
"Adrián Martínez Larumbe" <adrian.larumbe@collabora.com>,
"Boris Brezillon" <boris.brezillon@collabora.com>,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"Sebastian Reichel" <sebastian.reichel@collabora.com>,
kernel@collabora.com
Subject: Re: [PATCH v1 2/6] pmdomain: rockchip: cleanup mutex handling in rockchip_pd_power
Date: Tue, 10 Sep 2024 20:23:02 +0200 [thread overview]
Message-ID: <4864529.A9s0UXYOmP@diego> (raw)
In-Reply-To: <20240910180530.47194-3-sebastian.reichel@collabora.com>
Am Dienstag, 10. September 2024, 19:57:11 CEST schrieb Sebastian Reichel:
> Use the cleanup infrastructure to handle the mutex, which
> slightly improve code readability for this function.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
I guess you could make the guard patch the 1st to not add and then
remove the mutex_unlock in the "forward errors" patch.
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: "Elaine Zhang" <zhangqing@rock-chips.com>,
"Adrián Martínez Larumbe" <adrian.larumbe@collabora.com>,
"Boris Brezillon" <boris.brezillon@collabora.com>,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"Sebastian Reichel" <sebastian.reichel@collabora.com>,
kernel@collabora.com
Subject: Re: [PATCH v1 2/6] pmdomain: rockchip: cleanup mutex handling in rockchip_pd_power
Date: Tue, 10 Sep 2024 20:23:02 +0200 [thread overview]
Message-ID: <4864529.A9s0UXYOmP@diego> (raw)
In-Reply-To: <20240910180530.47194-3-sebastian.reichel@collabora.com>
Am Dienstag, 10. September 2024, 19:57:11 CEST schrieb Sebastian Reichel:
> Use the cleanup infrastructure to handle the mutex, which
> slightly improve code readability for this function.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
I guess you could make the guard patch the 1st to not add and then
remove the mutex_unlock in the "forward errors" patch.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-09-10 18:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 17:57 [PATCH v1 0/6] Fix RK3588 GPU domain Sebastian Reichel
2024-09-10 17:57 ` Sebastian Reichel
2024-09-10 17:57 ` [PATCH v1 1/6] pmdomain: rockchip: forward rockchip_do_pmu_set_power_domain errors Sebastian Reichel
2024-09-10 17:57 ` Sebastian Reichel
2024-09-10 18:21 ` Heiko Stübner
2024-09-10 18:21 ` Heiko Stübner
2024-09-10 17:57 ` [PATCH v1 2/6] pmdomain: rockchip: cleanup mutex handling in rockchip_pd_power Sebastian Reichel
2024-09-10 17:57 ` Sebastian Reichel
2024-09-10 18:23 ` Heiko Stübner [this message]
2024-09-10 18:23 ` Heiko Stübner
2024-09-10 17:57 ` [PATCH v1 3/6] pmdomain: rockchip: reduce indention " Sebastian Reichel
2024-09-10 17:57 ` Sebastian Reichel
2024-09-10 18:26 ` Heiko Stübner
2024-09-10 18:26 ` Heiko Stübner
2024-09-10 17:57 ` [PATCH v1 4/6] dt-bindings: power: rockchip: add regulator support Sebastian Reichel
2024-09-10 17:57 ` Sebastian Reichel
2024-09-10 18:52 ` Heiko Stübner
2024-09-10 18:52 ` Heiko Stübner
2024-09-11 17:38 ` Rob Herring (Arm)
2024-09-11 17:38 ` Rob Herring (Arm)
2024-09-10 17:57 ` [PATCH v1 5/6] pmdomain: " Sebastian Reichel
2024-09-10 17:57 ` Sebastian Reichel
2024-09-11 9:46 ` Heiko Stübner
2024-09-11 9:46 ` Heiko Stübner
2024-09-16 12:37 ` Heiko Stuebner
2024-09-16 12:37 ` Heiko Stuebner
2024-09-10 17:57 ` [PATCH v1 6/6] arm64: dts: rockchip: Add GPU power domain regulator dependency for RK3588 Sebastian Reichel
2024-09-10 17:57 ` Sebastian Reichel
2024-09-13 11:59 ` [PATCH v1 0/6] Fix RK3588 GPU domain Ulf Hansson
2024-09-13 11:59 ` Ulf Hansson
2024-09-19 9:05 ` Sebastian Reichel
2024-09-19 9:05 ` Sebastian Reichel
2024-09-16 15:45 ` Adrián Martínez Larumbe
2024-09-16 15:45 ` Adrián Martínez Larumbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4864529.A9s0UXYOmP@diego \
--to=heiko@sntech.de \
--cc=adrian.larumbe@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=ulf.hansson@linaro.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.