From: Jeff Garzik <jeff@garzik.org>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org, Sathya Narayanan <sathyan@teamf1.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH V2] ibm_newemac: Fixes kernel crashes when speed of cable connected changes
Date: Fri, 27 Jun 2008 01:14:30 -0400 [thread overview]
Message-ID: <48647736.3080704@garzik.org> (raw)
In-Reply-To: <1214246162-25293-1-git-send-email-sr@denx.de>
Stefan Roese wrote:
> From: Sathya Narayanan <sathyan@teamf1.com>
>
> The descriptor pointers were not initialized to NIL values, so it was
> poiniting to some random addresses which was completely invalid. This
> fix takes care of initializing the descriptor to NIL values and clearing
> the valid descriptors on clean ring operation.
>
> Signed-off-by: Sathya Narayanan <sathyan@teamf1.com>
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
> Changed since V1:
> - Fixed off-by-one error in for loops
>
> drivers/net/ibm_newemac/core.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
I didn't see any answers to ben h's questions?
Holding this patch, waiting for ben's ack...
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
benh@kernel.crashing.org, Sathya Narayanan <sathyan@teamf1.com>
Subject: Re: [PATCH V2] ibm_newemac: Fixes kernel crashes when speed of cable connected changes
Date: Fri, 27 Jun 2008 01:14:30 -0400 [thread overview]
Message-ID: <48647736.3080704@garzik.org> (raw)
In-Reply-To: <1214246162-25293-1-git-send-email-sr@denx.de>
Stefan Roese wrote:
> From: Sathya Narayanan <sathyan@teamf1.com>
>
> The descriptor pointers were not initialized to NIL values, so it was
> poiniting to some random addresses which was completely invalid. This
> fix takes care of initializing the descriptor to NIL values and clearing
> the valid descriptors on clean ring operation.
>
> Signed-off-by: Sathya Narayanan <sathyan@teamf1.com>
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
> Changed since V1:
> - Fixed off-by-one error in for loops
>
> drivers/net/ibm_newemac/core.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
I didn't see any answers to ben h's questions?
Holding this patch, waiting for ben's ack...
next prev parent reply other threads:[~2008-06-27 5:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 18:36 [PATCH V2] ibm_newemac: Fixes kernel crashes when speed of cable connected changes Stefan Roese
2008-06-23 18:36 ` Stefan Roese
2008-06-27 5:14 ` Jeff Garzik [this message]
2008-06-27 5:14 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48647736.3080704@garzik.org \
--to=jeff@garzik.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sathyan@teamf1.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.