From: Jeff Garzik <jeff@garzik.org>
To: Tobias Diedrich <ranma+kernel@tdiedrich.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ayaz Abdulla <aabdulla@nvidia.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Stephen Hemminger <shemminger@linux-foundation.org>
Subject: Re: [PATCH 5/4] Fix forcedeth hibernate/wake-on-lan problems
Date: Fri, 27 Jun 2008 02:09:55 -0400 [thread overview]
Message-ID: <48648433.6070200@garzik.org> (raw)
In-Reply-To: <20080531225442.GA2747@yamamaya.is-a-geek.org>
Tobias Diedrich wrote:
> From: Tobias Diedrich <ranma+kernel@tdiedrich.de>
>
> We currently don't signal the kernel we that this device can wake
> the system. Call device_init_wakeup() to correct this.
> Without this device_can_wakeup and device_may_wakeup will return
> incorrect values.
> Together with the minimized acpi wakeup patch (6/4 ;)), which will
> follow in the next mail, this really makes wake-on-lan work for me
> as expected (i.e. "ethtool -s eth0 wol g" is sufficient, no
> additional magic needed).
>
> Signed-off-by: Tobias Diedrich <ranma+kernel@tdiedrich.de>
applied 5-6
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: Tobias Diedrich <ranma+kernel@tdiedrich.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ayaz Abdulla <aabdulla@nvidia.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Stephen Hemm
Subject: Re: [PATCH 5/4] Fix forcedeth hibernate/wake-on-lan problems
Date: Fri, 27 Jun 2008 02:09:55 -0400 [thread overview]
Message-ID: <48648433.6070200@garzik.org> (raw)
In-Reply-To: <20080531225442.GA2747@yamamaya.is-a-geek.org>
Tobias Diedrich wrote:
> From: Tobias Diedrich <ranma+kernel@tdiedrich.de>
>
> We currently don't signal the kernel we that this device can wake
> the system. Call device_init_wakeup() to correct this.
> Without this device_can_wakeup and device_may_wakeup will return
> incorrect values.
> Together with the minimized acpi wakeup patch (6/4 ;)), which will
> follow in the next mail, this really makes wake-on-lan work for me
> as expected (i.e. "ethtool -s eth0 wol g" is sufficient, no
> additional magic needed).
>
> Signed-off-by: Tobias Diedrich <ranma+kernel@tdiedrich.de>
applied 5-6
next prev parent reply other threads:[~2008-06-27 6:10 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 12:57 [PATCH 0/4] Fix forcedeth hibernate/wake-on-lan problems Tobias Diedrich
2008-05-18 13:00 ` [PATCH 1/4] Restore multicast settings on resume Tobias Diedrich
2008-05-22 10:21 ` Jeff Garzik
2008-05-22 10:21 ` Jeff Garzik
2008-05-18 13:02 ` [PATCH 2/4] setup wake-on-lan before shutting down Tobias Diedrich
2008-05-31 2:20 ` Jeff Garzik
2008-05-31 2:20 ` Jeff Garzik
2008-05-18 13:03 ` [PATCH 3/4] save/restore device configuration space Tobias Diedrich
2008-05-18 13:04 ` [PATCH 4/4] reorder suspend/resume code Tobias Diedrich
2008-05-18 15:09 ` [PATCH 0/4] Fix forcedeth hibernate/wake-on-lan problems Tobias Diedrich
2008-05-20 22:39 ` Rafael J. Wysocki
2008-05-25 15:04 ` Tobias Diedrich
2008-05-25 18:13 ` Tobias Diedrich
2008-05-27 6:21 ` Tobias Diedrich
2008-05-27 6:21 ` Tobias Diedrich
2008-05-27 6:21 ` Tobias Diedrich
2008-05-27 6:21 ` Tobias Diedrich
2008-05-27 21:32 ` David Brownell
2008-05-31 7:20 ` Pavel Machek
2008-06-05 2:38 ` David Brownell
2008-06-05 2:38 ` David Brownell
2008-05-31 7:20 ` Pavel Machek
2008-05-27 21:32 ` David Brownell
2008-05-31 22:12 ` Tobias Diedrich
2008-05-31 22:12 ` Tobias Diedrich
2008-05-31 22:12 ` Tobias Diedrich
2008-06-01 2:51 ` [linux-pm] " Alan Stern
2008-06-01 2:51 ` Alan Stern
2008-06-01 7:49 ` Tobias Diedrich
2008-06-01 7:49 ` [linux-pm] " Tobias Diedrich
2008-06-02 21:09 ` Alan Stern
2008-06-02 21:09 ` [linux-pm] " Alan Stern
2008-06-02 21:09 ` Alan Stern
2008-06-03 6:16 ` Tobias Diedrich
2008-06-03 6:16 ` [linux-pm] " Tobias Diedrich
2008-06-03 14:12 ` Alan Stern
2008-06-03 14:12 ` [linux-pm] " Alan Stern
2008-06-03 14:12 ` Alan Stern
2008-06-03 17:30 ` Tobias Diedrich
2008-06-03 17:30 ` [linux-pm] " Tobias Diedrich
2008-06-03 20:06 ` Alan Stern
2008-06-03 20:06 ` [linux-pm] " Alan Stern
2008-06-03 20:06 ` Alan Stern
2008-06-01 2:51 ` Alan Stern
2008-05-31 22:54 ` [PATCH 5/4] " Tobias Diedrich
2008-06-27 6:09 ` Jeff Garzik [this message]
2008-06-27 6:09 ` Jeff Garzik
2008-05-31 23:20 ` [PATCH 6/4] " Tobias Diedrich
2008-05-31 23:20 ` Tobias Diedrich
2008-05-31 23:20 ` Tobias Diedrich
2008-05-31 23:20 ` Tobias Diedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48648433.6070200@garzik.org \
--to=jeff@garzik.org \
--cc=aabdulla@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ranma+kernel@tdiedrich.de \
--cc=rjw@sisk.pl \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.