* [PATCH #upstream-fixes] sata_uli: hardreset is broken
@ 2008-06-21 7:07 Tejun Heo
2008-06-27 7:00 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2008-06-21 7:07 UTC (permalink / raw)
To: Jeff Garzik, IDE/ATA development list, casteyde.christian
sata_uli can't do hardresets reliably and lock up. This went
unnoticed till now as softreset was the default and hardreset was only
used after softreset failed.
Reported by Christian Casteyde in bz#10860.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Christian Casteyde <casteyde.christian@free.fr>
---
drivers/ata/sata_uli.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/sata_uli.c b/drivers/ata/sata_uli.c
index f277cea..db529b8 100644
--- a/drivers/ata/sata_uli.c
+++ b/drivers/ata/sata_uli.c
@@ -83,6 +83,7 @@ static struct ata_port_operations uli_ops = {
.inherits = &ata_bmdma_port_ops,
.scr_read = uli_scr_read,
.scr_write = uli_scr_write,
+ .hardreset = ATA_OP_NULL,
};
static const struct ata_port_info uli_port_info = {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH #upstream-fixes] sata_uli: hardreset is broken
2008-06-21 7:07 [PATCH #upstream-fixes] sata_uli: hardreset is broken Tejun Heo
@ 2008-06-27 7:00 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-06-27 7:00 UTC (permalink / raw)
To: Tejun Heo; +Cc: IDE/ATA development list, casteyde.christian
Tejun Heo wrote:
> sata_uli can't do hardresets reliably and lock up. This went
> unnoticed till now as softreset was the default and hardreset was only
> used after softreset failed.
>
> Reported by Christian Casteyde in bz#10860.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Christian Casteyde <casteyde.christian@free.fr>
> ---
> drivers/ata/sata_uli.c | 1 +
> 1 file changed, 1 insertion(+)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-27 7:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-21 7:07 [PATCH #upstream-fixes] sata_uli: hardreset is broken Tejun Heo
2008-06-27 7:00 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.