[Cluster-devel] [PATCH 00/20] gfs2-utils: Misc. tidy-ups

[Bob Peterson <rpeterso@redhat.com>]

----- Original Message -----
| This is an accumulation of yak shaving patches and cleanups that I want to
| get out of the way. There shouldn't be anything controversial here. The main
| theme is to make it easier to use libgfs2 without using gfs2_buffer_heads,
| and it gets rid of some 'dummy_bh' uses.
| 
| Andrew Price (20):
|   libgfs2: Remove unused lock* fields from gfs2_sbd
|   libgfs2: Remove sb_addr from gfs2_sbd
|   libgfs2: Plug an alignment hole in gfs2_sbd
|   libgfs2: Plug an alignment hole in gfs2_buffer_head
|   libgfs2: Plug an alignment hole in gfs2_inode
|   libgfs2: Remove gfs2_meta_header_out_bh()
|   libgfs2: Don't pass an extlen to block_map where not required
|   libgfs2: Don't use a buffer_head in gfs2_meta_header_in
|   libgfs2: Don't use buffer_heads in gfs2_sb_in
|   libgfs2: Don't use buffer_heads in gfs2_rgrp_in
|   libgfs2: Remove gfs2_rgrp_out_bh
|   libgfs2: Don't use buffer_heads in gfs2_dinode_in
|   libgfs2: Remove gfs2_dinode_out_bh
|   libgfs2: Don't use buffer_heads in gfs2_leaf_{in,out}
|   libgfs2: Don't use buffer_heads in gfs2_log_header_in
|   libgfs2: Remove gfs2_log_header_out_bh
|   libgfs2: Don't use buffer_heads in gfs2_log_descriptor_{in,out}
|   libgfs2: Don't use buffer_heads in gfs2_quota_change_{in,out}
|   libgfs2: Fix two unused variable warnings
|   mkfs.gfs2: Silence an integer overflow warning
| 
|  gfs2/convert/gfs2_convert.c |  25 ++++++----
|  gfs2/edit/extended.c        |   2 +-
|  gfs2/edit/gfs2hex.c         |  22 ++++-----
|  gfs2/edit/hexedit.c         |  19 +++----
|  gfs2/edit/journal.c         |  29 +++++------
|  gfs2/edit/savemeta.c        |  26 +++++-----
|  gfs2/fsck/fs_recovery.c     |  10 ++--
|  gfs2/fsck/fsck.h            |   4 +-
|  gfs2/fsck/initialize.c      |  10 ++--
|  gfs2/fsck/lost_n_found.c    |   2 +-
|  gfs2/fsck/metawalk.c        |  13 +++--
|  gfs2/fsck/pass1.c           |   4 +-
|  gfs2/fsck/pass2.c           |   6 +--
|  gfs2/fsck/pass5.c           |   2 +-
|  gfs2/fsck/rgrepair.c        |  39 +++++++--------
|  gfs2/glocktop/glocktop.c    |   2 +-
|  gfs2/libgfs2/fs_bits.c      |   2 +-
|  gfs2/libgfs2/fs_geometry.c  |   5 +-
|  gfs2/libgfs2/fs_ops.c       |  46 ++++++++++-------
|  gfs2/libgfs2/gfs1.c         |  16 +++---
|  gfs2/libgfs2/lang.c         |   2 +-
|  gfs2/libgfs2/libgfs2.h      |  46 ++++++-----------
|  gfs2/libgfs2/misc.c         |   2 -
|  gfs2/libgfs2/ondisk.c       | 118
|  +++++++++++++++++---------------------------
|  gfs2/libgfs2/recovery.c     |   9 ++--
|  gfs2/libgfs2/rgrp.c         |   2 +-
|  gfs2/libgfs2/structures.c   |  13 ++---
|  gfs2/libgfs2/super.c        |   3 +-
|  gfs2/mkfs/main_jadd.c       |   8 ++-
|  gfs2/mkfs/main_mkfs.c       |   6 +--
|  30 files changed, 229 insertions(+), 264 deletions(-)
| 
| --
| 2.14.3
| 
| 
Hi,

These all look good to me. The only one that worries me is
patch 02/20 because historically speaking, I've had problems
with some of the tools due to the delicate order of how the
superblock is read in versus the various calculations done.
In other words, in the past, changes like 02/20 would be
transparent and "just work" for one util, but completely
break a different util. In those cases, the breakage was pretty
easy to uncover, because the util would just refuse to do any
basic operations at all. So just make sure all the tools are
tested for base functionality, if you haven't already.

Regards,

Bob Peterson
Red Hat File Systems