From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 17/20] libgfs2: Don't use buffer_heads in gfs2_log_descriptor_{in, out}
Date: Mon, 5 Mar 2018 14:00:48 -0500 (EST) [thread overview]
Message-ID: <1890018040.7997557.1520276448893.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20180305182549.17817-18-anprice@redhat.com>
----- Original Message -----
| Signed-off-by: Andrew Price <anprice@redhat.com>
| ---
| gfs2/edit/gfs2hex.c | 2 +-
| gfs2/edit/journal.c | 21 +++++++++------------
| gfs2/libgfs2/libgfs2.h | 6 ++----
| gfs2/libgfs2/ondisk.c | 15 ++++++---------
| 4 files changed, 18 insertions(+), 26 deletions(-)
| +extern void gfs2_log_descriptor_out(struct gfs2_log_descriptor *ld, char
| *buf);
Hm. Looks like gfs2_log_descriptor_out isn't used by any of the utils.
We went through a phase where we tried to trim down libgfs2 in favor of
moving functions like this to the gfs2-util that uses it, in cases where
only one tool used it. Perhaps we should get rid of it altogether?
Unless you want to keep it in case third party tools link it in.
Regards,
Bob
next prev parent reply other threads:[~2018-03-05 19:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 18:25 [Cluster-devel] [PATCH 00/20] gfs2-utils: Misc. tidy-ups Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 01/20] libgfs2: Remove unused lock* fields from gfs2_sbd Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 02/20] libgfs2: Remove sb_addr " Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 03/20] libgfs2: Plug an alignment hole in gfs2_sbd Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 04/20] libgfs2: Plug an alignment hole in gfs2_buffer_head Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 05/20] libgfs2: Plug an alignment hole in gfs2_inode Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 06/20] libgfs2: Remove gfs2_meta_header_out_bh() Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 07/20] libgfs2: Don't pass an extlen to block_map where not required Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 08/20] libgfs2: Don't use a buffer_head in gfs2_meta_header_in Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 09/20] libgfs2: Don't use buffer_heads in gfs2_sb_in Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 10/20] libgfs2: Don't use buffer_heads in gfs2_rgrp_in Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 11/20] libgfs2: Remove gfs2_rgrp_out_bh Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 12/20] libgfs2: Don't use buffer_heads in gfs2_dinode_in Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 13/20] libgfs2: Remove gfs2_dinode_out_bh Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 14/20] libgfs2: Don't use buffer_heads in gfs2_leaf_{in, out} Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 15/20] libgfs2: Don't use buffer_heads in gfs2_log_header_in Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 16/20] libgfs2: Remove gfs2_log_header_out_bh Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 17/20] libgfs2: Don't use buffer_heads in gfs2_log_descriptor_{in, out} Andrew Price
2018-03-05 19:00 ` Bob Peterson [this message]
2018-03-05 19:15 ` Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 18/20] libgfs2: Don't use buffer_heads in gfs2_quota_change_{in, out} Andrew Price
2018-03-05 19:02 ` Bob Peterson
2018-03-05 18:25 ` [Cluster-devel] [PATCH 19/20] libgfs2: Fix two unused variable warnings Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 20/20] mkfs.gfs2: Silence an integer overflow warning Andrew Price
2018-03-05 19:08 ` [Cluster-devel] [PATCH 00/20] gfs2-utils: Misc. tidy-ups Bob Peterson
2018-03-05 19:19 ` Andrew Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1890018040.7997557.1520276448893.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.