Re: [PATCH] Log qemu-dm's message with date, time and pid

[Kevin Wolf <kwolf@suse.de>]

Yuji Shimada schrieb:
> I agree with developing proper logging functions. But without these
> functions, I think ioemu-logger is a good solution.
> 
> We can reboot xend by the following command.
>   # /etc/init.d/xend restart
> Running of guest domains must not be affected by rebooting xend.

This seems to be a valid point.

> I'm sure that ioemu-logger dying is rare case. But there is no guarantee
> that it doesn't die.
> If xend starts ioemu-logger, xend loses one end of a pipe by rebooting
> xend. After that, xend can't associates stdin for ioemu-logger with the
> pipe when xend restarts ioemu-logger after ioemu-logger dies. This
> problem happens because the life cycle of xend and qemu-dm is different.
> So I think to start ioemu-logger by qemu-dm is more simple.
> 
> Using named pipe (FIFO), it's possible to start ioemu-logger by xend.
> But sorry, I don't know about python well. Could anyone develope it?

I'm under the impression that you're completely missing my (and Ian's)
point. Actually, I'm not talking about having ioemu-logger started by
xend. I'm talking about not having ioemu-logger at all (at least not as
a new external tool). Xen has already too many of these small tools,
IMHO, and we shouldn't add even more to them without need.

So, please implement it in qemu-dm instead of an external tool, if xend
is not possible.

Kevin