[PATCH] p54: Add quality output to iwlist and iwconfig

[PATCH] p54: Add quality output to iwlist and iwconfig

[Larry.Finger]

The p54 driver family reports a quality of 0 in iwconfig and iwlist
output. This patch calculates a quality number as a percentage of the
rssi to the maximum signal of 127 reported as the maximum signal.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---

Index: wireless-testing/drivers/net/wireless/p54/p54common.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/p54/p54common.c
+++ wireless-testing/drivers/net/wireless/p54/p54common.c
@@ -357,6 +357,7 @@ static void p54_rx_data(struct ieee80211
 
 	rx_status.signal = hdr->rssi;
 	/* XX correct? */
+	rx_status.qual = (100 * hdr->rssi) / 127;
 	rx_status.rate_idx = hdr->rate & 0xf;
 	rx_status.freq = freq;
 	rx_status.band = IEEE80211_BAND_2GHZ;

Re: [PATCH] p54: Add quality output to iwlist and iwconfig

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

On Mon, 2008-06-30 at 10:39 -0500, Larry.Finger@lwfinger.net wrote:
> The p54 driver family reports a quality of 0 in iwconfig and iwlist
> output. This patch calculates a quality number as a percentage of the
> rssi to the maximum signal of 127 reported as the maximum signal.

Unrelated, do you have a p54 card? Does it work? I wasn't sure whether
the tx-info sbk->cb change broke it or not after I fixed up some things
there.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] p54: Add quality output to iwlist and iwconfig

[Larry Finger]

Johannes Berg wrote:
> On Mon, 2008-06-30 at 10:39 -0500, Larry.Finger@lwfinger.net wrote:
>> The p54 driver family reports a quality of 0 in iwconfig and iwlist
>> output. This patch calculates a quality number as a percentage of the
>> rssi to the maximum signal of 127 reported as the maximum signal.
> 
> Unrelated, do you have a p54 card? Does it work? I wasn't sure whether
> the tx-info sbk->cb change broke it or not after I fixed up some things
> there.

It is DW1450, which is a p54usb. It works with the latest wireless 
testing, at least in b/g/mode. I don't have an 802.11a AP to try the 5 
GHz mode.

Larry

Re: [PATCH] p54: Add quality output to iwlist and iwconfig

[Stefanik Gábor]

On Mon, Jun 30, 2008 at 6:07 PM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Johannes Berg wrote:
>>
>> On Mon, 2008-06-30 at 10:39 -0500, Larry.Finger@lwfinger.net wrote:
>>>
>>> The p54 driver family reports a quality of 0 in iwconfig and iwlist
>>> output. This patch calculates a quality number as a percentage of the
>>> rssi to the maximum signal of 127 reported as the maximum signal.
>>
>> Unrelated, do you have a p54 card? Does it work? I wasn't sure whether
>> the tx-info sbk->cb change broke it or not after I fixed up some things
>> there.
>
> It is DW1450, which is a p54usb. It works with the latest wireless testing,
> at least in b/g/mode. I don't have an 802.11a AP to try the 5 GHz mode.
>
> Larry
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

What "special" modes work with it? (IBSS, monitor, AP, mesh, etc.)

-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

Re: [PATCH] p54: Add quality output to iwlist and iwconfig

[Larry Finger]

Stefanik G=E1bor wrote:
> On Mon, Jun 30, 2008 at 6:07 PM, Larry Finger <Larry.Finger@lwfinger.=
net> wrote:
>> Johannes Berg wrote:
>>> On Mon, 2008-06-30 at 10:39 -0500, Larry.Finger@lwfinger.net wrote:
>>>> The p54 driver family reports a quality of 0 in iwconfig and iwlis=
t
>>>> output. This patch calculates a quality number as a percentage of =
the
>>>> rssi to the maximum signal of 127 reported as the maximum signal.
>>> Unrelated, do you have a p54 card? Does it work? I wasn't sure whet=
her
>>> the tx-info sbk->cb change broke it or not after I fixed up some th=
ings
>>> there.
>> It is DW1450, which is a p54usb. It works with the latest wireless t=
esting,
>> at least in b/g/mode. I don't have an 802.11a AP to try the 5 GHz mo=
de.
 >
>=20
> What "special" modes work with it? (IBSS, monitor, AP, mesh, etc.)

I have only run it in managed mode. I bought it to use it in AP mode=20
to test my BCM4312 802.11a/b/g card when b43 can handle 5 GHz=20
channels, but that is for the future.

I gave a quick try of monitor mode with kismet. It saw the beacons=20
from nearby APs, but never captured any other packets. I don't think=20
it is working.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] p54: Add quality output to iwlist and iwconfig

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

On Mon, 2008-06-30 at 11:07 -0500, Larry Finger wrote:
> Johannes Berg wrote:
> > On Mon, 2008-06-30 at 10:39 -0500, Larry.Finger@lwfinger.net wrote:
> >> The p54 driver family reports a quality of 0 in iwconfig and iwlist
> >> output. This patch calculates a quality number as a percentage of the
> >> rssi to the maximum signal of 127 reported as the maximum signal.
> > 
> > Unrelated, do you have a p54 card? Does it work? I wasn't sure whether
> > the tx-info sbk->cb change broke it or not after I fixed up some things
> > there.
> 
> It is DW1450, which is a p54usb. It works with the latest wireless 
> testing, at least in b/g/mode. I don't have an 802.11a AP to try the 5 
> GHz mode.

Great, thanks, I guess I did find all the problems then.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]