Re: [PATCH2/2] [POWERPC] CPM1: implement GPIO LIB API on CPM1 Freescale SoC.

[Jochen Friedrich <jochen@scram.de>]

Hi Grant,

sorry for the late response on this one.

> 2. You need to specifiy exact chip names in your compatible string.
> "fsl,cpm1-pario-<bank>" is a made up thing.

>>  +       for_each_compatible_node(np, NULL, "fsl,cpm1-pario-bank16")
>>  +               cpm1_gpiochip_add16(np);
>>  +
>>  +       for_each_compatible_node(np, NULL, "fsl,cpm1-pario-bank32b")
>>  +               cpm1_gpiochip_add32(np);
>>  +
>>  +       /* Port E uses CPM2 layout */
>>  +       for_each_compatible_node(np, NULL, "fsl,cpm1-pario-bank32e")
>>  +               cpm2_gpiochip_add32(np);

What do you suggest here?

All GPIO ports of CPM1/CPM2 are on the SoC, so the chip name is in fact the CPU itself
(like fsl,mpc866-pario-bank16).


Thanks,
Jochen