All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
To: video4linux-list@redhat.com
Cc: linux-sh@vger.kernel.org
Subject: Re: [PATCH 06/07] videobuf: Add physically contiguous queue code
Date: Wed, 02 Jul 2008 07:43:19 +0000	[thread overview]
Message-ID: <486B3197.5000100@teltonika.lt> (raw)
In-Reply-To: <20080701124735.30446.89320.sendpatchset@rx1.opensource.se>

Heh. I have written almost identical videobuf driver also :)
You should run checkpatch.pl on this patch to correct some style
problems. Since your version is a little bit more generic than mine:

Acked-by: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>

Magnus Damm wrote:
> This patch adds support for videobuf queues made from physically
> contiguous memory. Useful for hardware such as the SuperH Mobile CEU
> which doesn't support scatter gatter bus mastering.
> 
> Since it may be difficult to allocate large chunks of physically
> contiguous memory after some uptime due to fragmentation, this code
> allocates memory using dma_alloc_coherent(). Architectures supporting
> dma_declare_coherent_memory() can easily avoid fragmentation issues
> by using dma_declare_coherent_memory() to force dma_alloc_coherent()
> to allocate from a certain pre-allocated memory area.
> 
> Signed-off-by: Magnus Damm <damm@igel.co.jp>


WARNING: multiple messages have this Message-ID (diff)
From: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
To: video4linux-list@redhat.com
Cc: video4linux-list@redhat.com, linux-sh@vger.kernel.org
Subject: Re: [PATCH 06/07] videobuf: Add physically contiguous queue code
Date: Wed, 02 Jul 2008 10:43:19 +0300	[thread overview]
Message-ID: <486B3197.5000100@teltonika.lt> (raw)
In-Reply-To: <20080701124735.30446.89320.sendpatchset@rx1.opensource.se>

Heh. I have written almost identical videobuf driver also :)
You should run checkpatch.pl on this patch to correct some style
problems. Since your version is a little bit more generic than mine:

Acked-by: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>

Magnus Damm wrote:
> This patch adds support for videobuf queues made from physically
> contiguous memory. Useful for hardware such as the SuperH Mobile CEU
> which doesn't support scatter gatter bus mastering.
> 
> Since it may be difficult to allocate large chunks of physically
> contiguous memory after some uptime due to fragmentation, this code
> allocates memory using dma_alloc_coherent(). Architectures supporting
> dma_declare_coherent_memory() can easily avoid fragmentation issues
> by using dma_declare_coherent_memory() to force dma_alloc_coherent()
> to allocate from a certain pre-allocated memory area.
> 
> Signed-off-by: Magnus Damm <damm@igel.co.jp>

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  reply	other threads:[~2008-07-02  7:43 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-01 12:46 [PATCH 00/07] soc_camera: SuperH Mobile CEU support Magnus Damm
2008-07-01 12:46 ` Magnus Damm
2008-07-01 12:46 ` [PATCH 01/07] soc_camera: Remove default spinlock operations Magnus Damm
2008-07-01 12:46   ` Magnus Damm
2008-07-01 12:46 ` [PATCH 02/07] soc_camera: Let the host select videobuf_queue type Magnus Damm
2008-07-01 12:46   ` Magnus Damm
2008-07-01 20:02   ` [PATCH 02/07] soc_camera: Let the host select videobuf_queue Guennadi Liakhovetski
2008-07-01 20:02     ` [PATCH 02/07] soc_camera: Let the host select videobuf_queue type Guennadi Liakhovetski
2008-07-02  2:50     ` Magnus Damm
2008-07-02  2:50       ` Magnus Damm
2008-07-02  7:27   ` [PATCH 02/07] soc_camera: Let the host select videobuf_queue Paulius Zaleckas
2008-07-02  7:27     ` [PATCH 02/07] soc_camera: Let the host select videobuf_queue type Paulius Zaleckas
2008-07-01 12:47 ` [PATCH 03/07] soc_camera: Remove vbq_ops and msize Magnus Damm
2008-07-01 12:47   ` Magnus Damm
2008-07-01 12:47 ` [PATCH 04/07] soc_camera: Remove unused file lock pointer Magnus Damm
2008-07-01 12:47   ` Magnus Damm
2008-07-01 12:47 ` [PATCH 05/07] soc_camera: Add 16-bit bus width support Magnus Damm
2008-07-01 12:47   ` Magnus Damm
2008-07-01 12:47 ` [PATCH 06/07] videobuf: Add physically contiguous queue code Magnus Damm
2008-07-01 12:47   ` Magnus Damm
2008-07-02  7:43   ` Paulius Zaleckas [this message]
2008-07-02  7:43     ` Paulius Zaleckas
     [not found]     ` <aec7e5c30807020232j1181ba9s43bc0e6920b18733@mail.gmail.com>
2008-07-02 10:42       ` Paulius Zaleckas
2008-07-02 10:42         ` Paulius Zaleckas
2008-07-04  9:08   ` Paulius Zaleckas
2008-07-04  9:08     ` Paulius Zaleckas
2008-07-01 12:47 ` [PATCH 07/07] sh_mobile_ceu_camera: Add SuperH Mobile CEU driver Magnus Damm
2008-07-01 12:47   ` Magnus Damm
2008-07-01 20:07   ` Guennadi Liakhovetski
2008-07-01 20:07     ` Guennadi Liakhovetski
2008-07-02  3:08     ` Magnus Damm
2008-07-02  3:08       ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486B3197.5000100@teltonika.lt \
    --to=paulius.zaleckas@teltonika.lt \
    --cc=linux-sh@vger.kernel.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.