Re: [PATCH 2/2] Netfilter: Accounting rework: ct_extend + 64bit counters (v3)

[Patrick McHardy <kaber@trash.net>]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

Krzysztof Oledzki wrote:
> (...)
> bool nf_ct_acct __read_mostly = NF_CT_ACCT_DEFAULT;
> (...)
> module_param_named(acct, nf_ct_acct, bool, 0644);        <- line 28
> (...)
> 
> net/netfilter/nf_conntrack_acct.c: In function '__check_acct':
> net/netfilter/nf_conntrack_acct.c:28: warning: return from incompatible 
> pointer type

Seems you're the first to try module_param_named with a bool :)
Does this help?




[-- Attachment #2: x --]
[-- Type: text/plain, Size: 667 bytes --]

diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
index ec62438..1663ab1 100644
--- a/include/linux/moduleparam.h
+++ b/include/linux/moduleparam.h
@@ -155,7 +155,7 @@ extern int param_get_charp(char *buffer, struct kernel_param *kp);
 
 extern int param_set_bool(const char *val, struct kernel_param *kp);
 extern int param_get_bool(char *buffer, struct kernel_param *kp);
-#define param_check_bool(name, p) __param_check(name, p, int)
+#define param_check_bool(name, p) __param_check(name, p, bool)
 
 extern int param_set_invbool(const char *val, struct kernel_param *kp);
 extern int param_get_invbool(char *buffer, struct kernel_param *kp);