Re: [PATCH 2/2] Netfilter: Accounting rework: ct_extend + 64bit counters (v3)

[Patrick McHardy <kaber@trash.net>]

Krzysztof Oledzki wrote:
> On Wed, 2 Jul 2008, Patrick McHardy wrote:
> 
>> Krzysztof Oledzki wrote:
>>> (...)
>>> bool nf_ct_acct __read_mostly = NF_CT_ACCT_DEFAULT;
>>> (...)
>>> module_param_named(acct, nf_ct_acct, bool, 0644);        <- line 28
>>> (...)
>>>
>>> net/netfilter/nf_conntrack_acct.c: In function '__check_acct':
>>> net/netfilter/nf_conntrack_acct.c:28: warning: return from 
>>> incompatible pointer type
>>
>> Seems you're the first to try module_param_named with a bool :)
>> Does this help?
> 
> It helps but produces a lot of warnings in other places:
> 
> kernel/printk.c: In function '__check_time':
> kernel/printk.c:570: warning: return from incompatible pointer type
> 
> arch/x86/kernel/cpu/mtrr/generic.c: In function '__check_show':
> arch/x86/kernel/cpu/mtrr/generic.c:46: warning: return from incompatible 
> pointer type
> 
> kernel/irq/spurious.c: In function '__check_noirqdebug':
> kernel/irq/spurious.c:230: warning: return from incompatible pointer type
> 
> (...)
> 
> How about keeping it int currently and then issuing a cleanup patch that 
> touches all variables used in module_param/module_param_named(..., bool, 
> ...)?

Ah I see. You're supposed to use an int for the variable and
bool only for module_param_named.