From: Filippo Zangheri <filippo.zangheri@yahoo.it>
To: Darren Jenkins <darrenrjenkins@gmail.com>
Cc: kernel Janitors <kernel-janitors@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
ipw2100-admin@linux.intel.com, yi.zhu@intel.com,
reinette.chatre@intel.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] drivers/net/wireless/iwlwifi/iwl-3945.c
Date: Wed, 02 Jul 2008 14:25:19 +0000 [thread overview]
Message-ID: <486B8FCF.8080201@yahoo.it> (raw)
In-Reply-To: <1214962647.18261.15.camel@localhost.localdomain>
(Cc'ing linux-wireless)
On 02/07/2008 03:37, Darren Jenkins\ wrote:
> G'day people
>
> Coverity CID: 2265 NEGATIVE_RETURNS
>
> "rate" is of an unsigned type, and the code requires a signed type.
> The following patch makes it so.
>
> Only compile tested.
>
> Signed-off-by: Darren Jenkins <darrenrjenkins@gmailcom>
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
> index 62a3d8f..31d38cd 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> @@ -449,7 +449,7 @@ static void iwl3945_dbg_report_frame(struct iwl3945_priv *priv,
>
> if (print_summary) {
> char *title;
> - u32 rate;
> + int rate;
>
> if (hundred)
> title = "100Frames";
--
Filippo Zangheri
GPG key ID: 0x6C1F2F2F
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Filippo Zangheri <filippo.zangheri@yahoo.it>
To: Darren Jenkins <darrenrjenkins@gmail.com>
Cc: kernel Janitors <kernel-janitors@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
ipw2100-admin@linux.intel.com, yi.zhu@intel.com,
reinette.chatre@intel.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] drivers/net/wireless/iwlwifi/iwl-3945.c
Date: Wed, 02 Jul 2008 16:25:19 +0200 [thread overview]
Message-ID: <486B8FCF.8080201@yahoo.it> (raw)
In-Reply-To: <1214962647.18261.15.camel@localhost.localdomain>
(Cc'ing linux-wireless)
On 02/07/2008 03:37, Darren Jenkins\ wrote:
> G'day people
>=20
> Coverity CID: 2265 NEGATIVE_RETURNS
>=20
> "rate" is of an unsigned type, and the code requires a signed type.
> The following patch makes it so.
>=20
> Only compile tested.
>=20
> =EF=BB=BFSigned-off-by: Darren Jenkins <darrenrjenkins@gmailcom>
>=20
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wi=
reless/iwlwifi/iwl-3945.c
> index 62a3d8f..31d38cd 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> @@ -449,7 +449,7 @@ static void iwl3945_dbg_report_frame(struct iwl39=
45_priv *priv,
> =20
> if (print_summary) {
> char *title;
> - u32 rate;
> + int rate;
> =20
> if (hundred)
> title =3D "100Frames";
--=20
=46ilippo Zangheri
GPG key ID: 0x6C1F2F2F
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Filippo Zangheri <filippo.zangheri@yahoo.it>
To: Darren Jenkins <darrenrjenkins@gmail.com>
Cc: kernel Janitors <kernel-janitors@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
ipw2100-admin@linux.intel.com, yi.zhu@intel.com,
reinette.chatre@intel.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] drivers/net/wireless/iwlwifi/iwl-3945.c
Date: Wed, 02 Jul 2008 16:25:19 +0200 [thread overview]
Message-ID: <486B8FCF.8080201@yahoo.it> (raw)
In-Reply-To: <1214962647.18261.15.camel@localhost.localdomain>
(Cc'ing linux-wireless)
On 02/07/2008 03:37, Darren Jenkins\ wrote:
> G'day people
>
> Coverity CID: 2265 NEGATIVE_RETURNS
>
> "rate" is of an unsigned type, and the code requires a signed type.
> The following patch makes it so.
>
> Only compile tested.
>
> Signed-off-by: Darren Jenkins <darrenrjenkins@gmailcom>
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
> index 62a3d8f..31d38cd 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> @@ -449,7 +449,7 @@ static void iwl3945_dbg_report_frame(struct iwl3945_priv *priv,
>
> if (print_summary) {
> char *title;
> - u32 rate;
> + int rate;
>
> if (hundred)
> title = "100Frames";
--
Filippo Zangheri
GPG key ID: 0x6C1F2F2F
next prev parent reply other threads:[~2008-07-02 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-02 1:37 [PATCH] drivers/net/wireless/iwlwifi/iwl-3945.c Darren Jenkins\
2008-07-02 1:37 ` Darren Jenkins\
2008-07-02 14:25 ` Filippo Zangheri [this message]
2008-07-02 14:25 ` Filippo Zangheri
2008-07-02 14:25 ` Filippo Zangheri
2008-07-02 19:24 ` John W. Linville
2008-07-02 19:24 ` John W. Linville
2008-07-03 1:51 ` Zhu Yi
2008-07-03 1:51 ` Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486B8FCF.8080201@yahoo.it \
--to=filippo.zangheri@yahoo.it \
--cc=darrenrjenkins@gmail.com \
--cc=ipw2100-admin@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.