build: quote variables in release.sh

build: quote variables in release.sh

[Jan Engelhardt]

commit 68a69d9fbf610899aa95457cdd5c38dcfa447c02
Author: Jan Engelhardt <jengelh@medozas.de>
Date:   Thu Jul 3 19:23:39 2008 +0200

    build: quote variables in release.sh
    
    Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
 release.sh |   22 +++++++++++-----------
 1 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/release.sh b/release.sh
index 5635e4c..f77ef25 100644
--- a/release.sh
+++ b/release.sh
@@ -7,14 +7,14 @@ PREV_VERSION=1.4.1
 TMPDIR=/tmp/ipt-release
 IPTDIR="$TMPDIR/iptables-$VERSION"
 
-PATCH=patch-iptables-$PREV_VERSION-$VERSION.bz2
-TARBALL=iptables-$VERSION.tar.bz2
-CHANGELOG=changes-iptables-$PREV_VERSION-$VERSION.txt
+PATCH="patch-iptables-$PREV_VERSION-$VERSION.bz2";
+TARBALL="iptables-$VERSION.tar.bz2";
+CHANGELOG="changes-iptables-$PREV_VERSION-$VERSION.txt";
 
 mkdir -p "$TMPDIR"
-git shortlog v$PREV_VERSION..v$VERSION > "$TMPDIR/$CHANGELOG"
-git diff v$PREV_VERSION..v$VERSION | bzip2 > "$TMPDIR/$PATCH"
-git archive --prefix=iptables-$VERSION/ v$VERSION | tar -xC "$TMPDIR/"
+git shortlog "v$PREV_VERSION..v$VERSION" > "$TMPDIR/$CHANGELOG"
+git diff "v$PREV_VERSION..v$VERSION" | bzip2 > "$TMPDIR/$PATCH"
+git archive --prefix="iptables-$VERSION/" "v$VERSION" | tar -xC "$TMPDIR/"
 
 cd "$IPTDIR" && {
 	sh autogen.sh
@@ -22,9 +22,9 @@ cd "$IPTDIR" && {
 	cd ..
 }
 
-tar -cjf $TARBALL iptables-$VERSION
-gpg -u "Netfilter Core Team" -sb $TARBALL
-md5sum $TARBALL > $TARBALL.md5sum
+tar -cjf "$TARBALL" "iptables-$VERSION";
+gpg -u "Netfilter Core Team" -sb "$TARBALL";
+md5sum "$TARBALL" >"$TARBALL.md5sum";
 
-gpg -u "Netfilter Core Team" -sb $PATCH
-md5sum $PATCH > $PATCH.md5sum
+gpg -u "Netfilter Core Team" -sb "$PATCH";
+md5sum "$PATCH" >"$PATCH.md5sum";

Re: build: quote variables in release.sh

[Patrick McHardy]

Jan Engelhardt wrote:
> commit 68a69d9fbf610899aa95457cdd5c38dcfa447c02
> Author: Jan Engelhardt <jengelh@medozas.de>
> Date:   Thu Jul 3 19:23:39 2008 +0200
> 
>     build: quote variables in release.sh
>     
>     Signed-off-by: Jan Engelhardt <jengelh@medozas.de>

I knew that wouldn't take long :) I actually didn't qoute all
those variables on purpose since neither git versions, nor
iptables versions, nor the filenames need this, but anyway,
applied.

Re: build: quote variables in release.sh

[Pablo Neira Ayuso]

Jan Engelhardt wrote:
> commit 68a69d9fbf610899aa95457cdd5c38dcfa447c02
> Author: Jan Engelhardt <jengelh@medozas.de>
> Date:   Thu Jul 3 19:23:39 2008 +0200
> 
>     build: quote variables in release.sh

Actually, instead of fixing release.sh, we should have the `make
distcheck' magic working. Currently it is broken.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers

Re: build: quote variables in release.sh

[Pablo Neira Ayuso]

Pablo Neira Ayuso wrote:
> Jan Engelhardt wrote:
>> commit 68a69d9fbf610899aa95457cdd5c38dcfa447c02
>> Author: Jan Engelhardt <jengelh@medozas.de>
>> Date:   Thu Jul 3 19:23:39 2008 +0200
>>
>>     build: quote variables in release.sh
> 
> Actually, instead of fixing release.sh, we should have the `make
> distcheck' magic working. Currently it is broken.

I mean the magic to build the tarball, of course.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers

Re: build: quote variables in release.sh

[Jan Engelhardt]

On Friday 2008-07-04 09:39, Pablo Neira Ayuso wrote:

>Pablo Neira Ayuso wrote:
>> Jan Engelhardt wrote:
>>> commit 68a69d9fbf610899aa95457cdd5c38dcfa447c02
>>> Author: Jan Engelhardt <jengelh@medozas.de>
>>> Date:   Thu Jul 3 19:23:39 2008 +0200
>>>
>>>     build: quote variables in release.sh
>> 
>> Actually, instead of fixing release.sh, we should have the `make
>> distcheck' magic working. Currently it is broken.
>
>I mean the magic to build the tarball, of course.

make tarball

Re: build: quote variables in release.sh

[Pablo Neira Ayuso]

Jan Engelhardt wrote:
> On Friday 2008-07-04 09:39, Pablo Neira Ayuso wrote:
> 
>> Pablo Neira Ayuso wrote:
>>> Jan Engelhardt wrote:
>>>> commit 68a69d9fbf610899aa95457cdd5c38dcfa447c02
>>>> Author: Jan Engelhardt <jengelh@medozas.de>
>>>> Date:   Thu Jul 3 19:23:39 2008 +0200
>>>>
>>>>     build: quote variables in release.sh
>>> Actually, instead of fixing release.sh, we should have the `make
>>> distcheck' magic working. Currently it is broken.
>> I mean the magic to build the tarball, of course.
> 
> make tarball

That works but it is doing far less checkings that `make distcheck' in
other packages.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers

Re: build: quote variables in release.sh

[Jan Engelhardt]

On Friday 2008-07-04 16:13, Pablo Neira Ayuso wrote:
>>>>>     build: quote variables in release.sh
>>>> Actually, instead of fixing release.sh, we should have the `make
>>>> distcheck' magic working. Currently it is broken.
>>> I mean the magic to build the tarball, of course.
>> 
>> make tarball
>
>That works but it is doing far less checkings that `make distcheck' in
>other packages.

What checks do we need?