From: Christopher Head <chead@cs.ubc.ca>
To: xen-devel@lists.xensource.com
Subject: Blktap extended device number support bug
Date: Fri, 04 Jul 2008 23:20:32 -0700 [thread overview]
Message-ID: <486F12B0.3070409@cs.ubc.ca> (raw)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
In xenlinux revision 582, domid_translate_t is redefined from containing
a pair of unsigned shorts to contain an unsigned short and a u32.
Unfortunately, down on lines 772 and 773 of drivers/xen/blktap/blktap.c,
a domid_translate_t is built out of an unsigned long. This of course
doesn't work, because domid_translate_t is now 48 bits long while
unsigned long is only 32. I suggest passing a pointer into the ioctl and
doing a proper user-to-kernel copy.
Also, the userspace tools in xen-3.2-testing also need modifying as they
have their own copy of the struct declaration (and will in any case need
updating to pass a pointer instead of the struct packed into an unsigned
long).
Chris
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: GnuPT 2.7.2
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkhvEq8ACgkQiD2svb/jCb7rOQCfUhWy+k+oJfGnu6tgJKVAdH4m
gccAn0AUoEE5MNJ6BLSVmytt5tHkIXHV
=VvIn
-----END PGP SIGNATURE-----
reply other threads:[~2008-07-05 6:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486F12B0.3070409@cs.ubc.ca \
--to=chead@cs.ubc.ca \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.