* [Ocfs2-devel] [PATCH 1/1] ocfs2/dlm: Fixes oops in dlm_new_lockres()
@ 2008-07-07 17:06 Sunil Mushran
2008-07-07 18:20 ` Mark Fasheh
0 siblings, 1 reply; 3+ messages in thread
From: Sunil Mushran @ 2008-07-07 17:06 UTC (permalink / raw)
To: ocfs2-devel
Patch fixes a race that can result in an oops while adding a
lockres to the dlm lockres tracking list.
Bug introduced by mainline commit 29576f8bb54045be944ba809d4fca1ad77c94165.
Signed-off-by: Sunil Mushran <sunil.mushran@oracle.com>
---
fs/ocfs2/dlm/dlmmaster.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
index efc015c..44f87ca 100644
--- a/fs/ocfs2/dlm/dlmmaster.c
+++ b/fs/ocfs2/dlm/dlmmaster.c
@@ -606,7 +606,9 @@ static void dlm_init_lockres(struct dlm_ctxt *dlm,
res->last_used = 0;
+ spin_lock(&dlm->spinlock);
list_add_tail(&res->tracking, &dlm->tracking_list);
+ spin_unlock(&dlm->spinlock);
memset(res->lvb, 0, DLM_LVB_LEN);
memset(res->refmap, 0, sizeof(res->refmap));
--
1.5.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Ocfs2-devel] [PATCH 1/1] ocfs2/dlm: Fixes oops in dlm_new_lockres()
2008-07-07 17:06 [Ocfs2-devel] [PATCH 1/1] ocfs2/dlm: Fixes oops in dlm_new_lockres() Sunil Mushran
@ 2008-07-07 18:20 ` Mark Fasheh
2008-07-07 18:34 ` Sunil Mushran
0 siblings, 1 reply; 3+ messages in thread
From: Mark Fasheh @ 2008-07-07 18:20 UTC (permalink / raw)
To: ocfs2-devel
On Mon, Jul 07, 2008 at 10:06:29AM -0700, Sunil Mushran wrote:
> Patch fixes a race that can result in an oops while adding a
> lockres to the dlm lockres tracking list.
>
> Bug introduced by mainline commit 29576f8bb54045be944ba809d4fca1ad77c94165.
Ok, looks good... What's the impact? This looks like perhaps I should be
pushing up upstream asap...
--Mark
--
Mark Fasheh
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Ocfs2-devel] [PATCH 1/1] ocfs2/dlm: Fixes oops in dlm_new_lockres()
2008-07-07 18:20 ` Mark Fasheh
@ 2008-07-07 18:34 ` Sunil Mushran
0 siblings, 0 replies; 3+ messages in thread
From: Sunil Mushran @ 2008-07-07 18:34 UTC (permalink / raw)
To: ocfs2-devel
http://oss.oracle.com/pipermail/ocfs2-devel/2008-July/002460.html
Yes... for pushing upstream.
User reported the oops over the weekend.
Mark Fasheh wrote:
> On Mon, Jul 07, 2008 at 10:06:29AM -0700, Sunil Mushran wrote:
>
>> Patch fixes a race that can result in an oops while adding a
>> lockres to the dlm lockres tracking list.
>>
>> Bug introduced by mainline commit 29576f8bb54045be944ba809d4fca1ad77c94165.
>>
>
> Ok, looks good... What's the impact? This looks like perhaps I should be
> pushing up upstream asap...
> --Mark
>
> --
> Mark Fasheh
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-07 18:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-07 17:06 [Ocfs2-devel] [PATCH 1/1] ocfs2/dlm: Fixes oops in dlm_new_lockres() Sunil Mushran
2008-07-07 18:20 ` Mark Fasheh
2008-07-07 18:34 ` Sunil Mushran
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.