[Xenomai-core] [PATCH] comedi: Fix include for do_div

[Xenomai-core] [PATCH] comedi: Fix include for do_div

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

Required with 2.6.26 where there is no more calc64. And asm/div64.h is
what you actually want.

Jan

PS: Kernel-style reformatting would be nice - one day... :->


Index: ksrc/drivers/comedi/instruction.c
===================================================================
--- ksrc/drivers/comedi/instruction.c	(Revision 4017)
+++ ksrc/drivers/comedi/instruction.c	(Arbeitskopie)
@@ -25,7 +25,7 @@
 #include <linux/module.h>
 #include <linux/ioport.h>
 #include <linux/mman.h>
-#include <linux/calc64.h>
+#include <asm/div64.h>
 #include <asm/io.h>
 #include <asm/errno.h>
 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

Re: [Xenomai-core] [PATCH] comedi: Fix include for do_div

[Alexis Berlemont]

Hi,

Sorry for answering so lately, I was not at home the last four days.

> Required with 2.6.26 where there is no more calc64. And asm/div64.h is
> what you actually want.

Thanks.

> PS: Kernel-style reformatting would be nice - one day... :->

Today or tomorrow, that sould be done.

Alexis.

Re: [Xenomai-core] [PATCH] comedi: Fix include for do_div

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Alexis Berlemont wrote:
> Hi,
> 
> Sorry for answering so lately, I was not at home the last four days.
> 
>> Required with 2.6.26 where there is no more calc64. And asm/div64.h is
>> what you actually want.
> 
> Thanks.

Sorry, but the committed fix is bogus for 2.6.26. I would suggest just
to pick up what I proposed, kernel headers do the same since ages
(including 2.4).

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

Re: [Xenomai-core] [PATCH] comedi: Fix include for do_div

[berlemont.hauw]

Hi,

> Sorry, but the committed fix is bogus for 2.6.26. I would suggest just
> to pick up what I proposed, kernel headers do the same since ages
> (including 2.4).

Argh... I am an [CENSORED].

I missed everything, I was in another dimension. I had a too quick look at your
fix (I saw linux/div64 instead of asm/div64) so I decided to put a temporary fix
(as I was running out of time to get some 2.6.26-rcx sources).

I will fix that tonight.

Sorry I will be more careful (next time, I directly apply your patch).

Alexis.

Re: [Xenomai-core] [PATCH] comedi: Fix include for do_div

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 670 bytes --]

berlemont.hauw@domain.hid wrote:
> Hi,
> 
>> Sorry, but the committed fix is bogus for 2.6.26. I would suggest just
>> to pick up what I proposed, kernel headers do the same since ages
>> (including 2.4).
> 
> Argh... I am an [CENSORED].
> 
> I missed everything, I was in another dimension. I had a too quick look at your
> fix (I saw linux/div64 instead of asm/div64) so I decided to put a temporary fix
> (as I was running out of time to get some 2.6.26-rcx sources).
> 
> I will fix that tonight.
> 
> Sorry I will be more careful (next time, I directly apply your patch).

(Please don't - I may post patches from other dimensions as well.) :)



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]