All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gregory Haskins" <ghaskins@novell.com>
To: <mingo@elte.hu>, <akpm@linux-foundation.org>,
	"David Howells" <dhowells@redhat.com>
Cc: <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix inc_rt_tasks() to not declare variable 'rq' if it's notneeded
Date: Fri, 11 Jul 2008 07:04:33 -0600	[thread overview]
Message-ID: <48772221.BA47.005A.0@novell.com> (raw)
In-Reply-To: <20080711123454.10475.33099.stgit@warthog.procyon.org.uk>

>>> On Fri, Jul 11, 2008 at  8:34 AM, in message
<20080711123454.10475.33099.stgit@warthog.procyon.org.uk>, David Howells
<dhowells@redhat.com> wrote: 
> Fix inc_rt_tasks() to not declare variable 'rq' if it's not needed.  It is
> declared if CONFIG_SMP or CONFIG_RT_GROUP_SCHED, but only used if 
> CONFIG_SMP.
> 
> This is a consequence of patch 1f11eb6a8bc92536d9e93ead48fa3ffbd1478571 plus
> patch 1100ac91b6af02d8639d518fad5b434b1bf44ed6.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>

Acked by: Gregory Haskins <ghaskins@novell.com>

> ---
> 
>  kernel/sched_rt.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
> index acba8eb..ec19ce5 100644
> --- a/kernel/sched_rt.c
> +++ b/kernel/sched_rt.c
> @@ -505,7 +505,9 @@ void inc_rt_tasks(struct sched_rt_entity *rt_se, struct 
> rt_rq *rt_rq)
>  	rt_rq->rt_nr_running++;
>  #if defined CONFIG_SMP || defined CONFIG_RT_GROUP_SCHED
>  	if (rt_se_prio(rt_se) < rt_rq->highest_prio) {
> +#ifdef CONFIG_SMP
>  		struct rq *rq = rq_of_rt_rq(rt_rq);
> +#endif
>  
>  		rt_rq->highest_prio = rt_se_prio(rt_se);
>  #ifdef CONFIG_SMP




  reply	other threads:[~2008-07-11 13:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-11 12:34 [PATCH] Fix inc_rt_tasks() to not declare variable 'rq' if it's not needed David Howells
2008-07-11 13:04 ` Gregory Haskins [this message]
2008-07-18 11:56 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48772221.BA47.005A.0@novell.com \
    --to=ghaskins@novell.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.